Repository navigation
GH-3289: Test CSV commands through CLI arguments - #3860
Open
zhangxinyao88 wants to merge 1 commit into
Open
zhangxinyao88 wants to merge 1 commit into
zhangxinyao88 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Continue #3289 with CLI coverage for
csv-schemaandconvert-csv. Existing command tests assign fields directly and mostly check return codes or file existence, leaving parsed arguments and resulting schemas/data untested.What changes are included in this PR?
Add nine cases using the existing CLI helper and small deterministic CSV files:
Inputs, schema files and output paths include spaces. Assertions use parsed schemas, record values and footer metadata without help-text snapshots. Existing read/inspection coverage in #3858 and #3859 is separate.
Are these changes tested?
./mvnw -o -B -ntp -pl parquet-cli spotless:check test: 92 cases, 90 passed, 2 skipped, no failures/errors. All nine new cases passed; Spotless and RAT license checks passed. Java 17 and existing cached dependencies were used; no full-reactor or multi-JDK build was run.Eight temporary local regression controls triggered assertion failures when required/no-header/output/schema/codec/multi-input/overwrite behavior was ignored or forced. All production edits were restored before the successful full-module run.
Are there any user-facing changes?
No. Tests only.