Repository navigation
GH-3289: Test file inspection through CLI arguments - #3859
Open
zhangxinyao88 wants to merge 1 commit into
Open
zhangxinyao88 wants to merge 1 commit into
zhangxinyao88 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Continue #3289 with argument-to-behavior coverage for
footer,pages, anddictionary. Existing footer and dictionary tests set command fields directly; the page-size tests also bypass CLI argument parsing. Thehead,cat, andscancoverage in #3858 is separate.What changes are included in this PR?
Add seven cases using the existing CLI helper and a deterministic two-column Parquet file:
footeremits interpreted metadata by default and raw Thrift metadata with--raw, with schema and row-count assertions on parsed JSON.pageslists both columns by default, honors--columns, and combines column selection with--rawpage headers.dictionary --columnemits the selected column's decoded values, checking both columns with distinct expected contents. The fixture is checked for dictionary-encoded pages.Assertions avoid complete formatted-output snapshots and dictionary ID ordering. Existing page-size tests remain intact.
Are these changes tested?
./mvnw -o -B -ntp -pl parquet-cli spotless:check testpassed: 90 cases, 0 failures/errors, 2 skipped (88 passed), including all seven new cases. Spotless and RAT license checks passed. The module used the existing local dependency cache; no full reactor or multi-JDK build was run.Six temporary local regression checks made the expected assertions fail when footer mode, page column selection/raw mode, or dictionary column selection was ignored. All temporary production edits were restored before the successful full-module run.
Are there any user-facing changes?
No. Tests only.