PostgreSQL: GENERATED { ALWAYS | BY DEFAULT } AS IDENTITY and GENERATED ALWAYS AS ( generation_expr ) support#832
Merged
Conversation
…basic impl - test are failing.
…_options ) and GENERATED ALWAYS AS ( generation_expr ) STORED implementation.
Pull Request Test Coverage Report for Build 4378470005
💛 - Coveralls |
Closed
mobuchowski
pushed a commit
to OpenLineage/sqlparser-rs
that referenced
this pull request
Aug 7, 2023
…ED ALWAYS AS ( generation_expr ) support (apache#832) * GENERATED { ALWAYS | BY DEFAULT } AS IDENTITY [ ( sequence_options ) basic impl - test are failing. * PostgreSQL GENERATED { ALWAYS | BY DEFAULT } AS IDENTITY [ ( sequence_options ) and GENERATED ALWAYS AS ( generation_expr ) STORED implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for ColumnDef -> ColumnOptions
Test cases are available at sqlparser_postgres.rs
and several clippy issues were fixed.
https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
This is continuation of #681