Skip to content

Support create sequence with options INCREMENT, MINVALUE, MAXVALUE, START etc.#681

Merged
alamb merged 9 commits into
apache:mainfrom
samjay000:create_sequence_with_options
Nov 3, 2022
Merged

Support create sequence with options INCREMENT, MINVALUE, MAXVALUE, START etc.#681
alamb merged 9 commits into
apache:mainfrom
samjay000:create_sequence_with_options

Conversation

@samjay000

@samjay000 samjay000 commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Support create sequence with options

    [ AS data_type ]
    [ INCREMENT [ BY ] increment ]
    [ MINVALUE minvalue | NO MINVALUE ] [ MAXVALUE maxvalue | NO MAXVALUE ]
    [ START [ WITH ] start ] [ CACHE cache ] [ [ NO ] CYCLE ]
    [ OWNED BY { table_name.column_name | NONE } ]

This is continuation of #678

@coveralls

coveralls commented Oct 20, 2022 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3380011029

  • 92 of 112 (82.14%) changed or added relevant lines in 3 files are covered.
  • 739 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.007%) to 85.956%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 46 53 86.79%
src/ast/mod.rs 36 49 73.47%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_snowflake.rs 1 96.83%
src/ast/value.rs 8 87.67%
src/ast/data_type.rs 13 88.62%
src/ast/ddl.rs 20 82.29%
tests/sqlparser_common.rs 54 96.85%
src/ast/mod.rs 264 77.07%
src/parser.rs 379 83.79%
Totals Coverage Status
Change from base Build 3292360592: 0.007%
Covered Lines: 11029
Relevant Lines: 12831
💛 - Coveralls

alamb
alamb approved these changes Oct 31, 2022
View reviewed changes

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @Sam-mmm

Comment thread src/ast/mod.rs
Comment thread src/ast/mod.rs
Comment thread src/ast/mod.rs Outdated
@samjay000 @alamb
Update src/ast/mod.rs
b152298 
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@alamb alamb merged commit bbf32a9 into apache:main Nov 3, 2022
@samjay000 samjay000 mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samjay000 @coveralls @alamb