Fix list backups after backup vm is expunged#9392
Merged
vishesh92 merged 1 commit intoJul 15, 2024
Merged
Conversation
Contributor
Author
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
14 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #9392 +/- ##
==========================================
Coverage 12.25% 12.25%
- Complexity 9316 9317 +1
==========================================
Files 4699 4699
Lines 414603 414608 +5
Branches 52169 52055 -114
==========================================
+ Hits 50821 50824 +3
- Misses 357474 357475 +1
- Partials 6308 6309 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10366 |
vishesh92
approved these changes
Jul 15, 2024
Member
vishesh92
left a comment
There was a problem hiding this comment.
lgtm.
Tested and verified. List backups works fine after the fix.
vishesh92
added a commit
that referenced
this pull request
Jul 15, 2024
* 4.18: Fix list backups after backup vm is expunged (#9392)
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jul 23, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jul 23, 2024
* 4.18: Fix list backups after backup vm is expunged (apache#9392)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes list backups after backup vm is expunged.
Issue: There is NPE when getting backup offering from the expunged VM, which is null (as it required to remove the backup offering assignment before expunging VM - introduced here: #5017)
Fixes #9341
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?