UI: Fix backup offering buttons for instances in data view#9391
Merged
sureshanaparti merged 1 commit intoJul 15, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9391 +/- ##
===========================================
Coverage 15.07% 15.07%
- Complexity 11170 11171 +1
===========================================
Files 5405 5405
Lines 472672 472672
Branches 60446 58552 -1894
===========================================
+ Hits 71271 71272 +1
Misses 393472 393472
+ Partials 7929 7928 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
14 tasks
|
UI build: ✔️ |
Contributor
|
Verified fix in qa simulator env. |
Contributor
|
code looks good in qa but removing the offering doesn't work: I am not sure if the icon should be added if the removal of the offering is not allowed. |
DaanHoogland
approved these changes
Jul 15, 2024
Contributor
DaanHoogland
left a comment
There was a problem hiding this comment.
some issue found but the change works as expected
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes backup offering buttons for instances in data view
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Image before the changes for a instance with a backup offering
Image after the changes for a instance with a backup offering
How Has This Been Tested?
Assign a backup offering to an instance and check the buttons in the data view.
How did you try to break this feature and the system with this change?