Skip to content

[4.5.3]Cherry-pick PR #795 into 4.5 branch.#817

Merged
asfgit merged 3 commits into
apache:4.5from
borisroman:4.5
Sep 18, 2015
Merged

[4.5.3]Cherry-pick PR #795 into 4.5 branch.#817
asfgit merged 3 commits into
apache:4.5from
borisroman:4.5

Conversation

@borisroman
Copy link
Copy Markdown
Contributor

@borisroman borisroman commented Sep 14, 2015

No description provided.

Boris Schrijver added 2 commits September 14, 2015 13:15
Added QCOW2 virtual size checking for S3.
a54dffc 
- Cleaned up S3TemplateDownloader
- Created static QCOW2 utils class.
- Reformatted some parts of DownloadManagerImpl
Fixed Findbugs issue introduced by 1c6378e PR apache#795.
dc670d5
@asfbot
Copy link
Copy Markdown

asfbot commented Sep 14, 2015

cloudstack-pull-analysis #534 ABORTED

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 14, 2015

cloudstack-pull-rats #598 ABORTED

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 15, 2015

4.5 was missing upgrade path, implemented that; please push again to force a travis build

@borisroman
Copy link
Copy Markdown
Contributor Author

borisroman commented Sep 15, 2015

@bhaisaab Still no luck. See error!

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 16, 2015

@borisroman not sure about the apache repo error, I'm having build failures when building locally due to getPreferredCharset method not avialable in StringUtils class (utils package). Please test locally and update the PR thanks.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 16, 2015

Also there seems to be a license header issue (missing new line between header and package definition in the utils class).

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 16, 2015

cloudstack-pull-rats #637 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 16, 2015

cloudstack-pull-analysis #576 SUCCESS
This pull request looks good

@borisroman
Copy link
Copy Markdown
Contributor Author

borisroman commented Sep 16, 2015

@bhaisaab Updated the PR. Tests run fine now. Thanks for your time!

@borisroman borisroman changed the title Cherry-pick PR #795 into 4.5 branch. [4.5.3]Cherry-pick PR #795 into 4.5 branch. Sep 17, 2015
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 18, 2015

LGTM, merging this this is already merged on master and builds are passing on 4.5 branch now

@asfgit asfgit merged commit 54595d1 into apache:4.5 Sep 18, 2015
asfgit pushed a commit that referenced this pull request Sep 18, 2015
@yadvr
Merge pull request #817 from borisroman/4.5
bab9938 
[4.5.3]Cherry-pick PR #795 into 4.5 branch.

* pr/817:
  Added Unit Tests for QCOW2Utils.
  Fixed Findbugs issue introduced by 1c6378e PR #795.
  Added QCOW2 virtual size checking for S3.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@davidjumani @yadvr
Destroying messages and notifications after logout (#817)
b671537 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@borisroman @asfbot @yadvr @asfgit