Skip to content

CLOUDSTACK-8819: Added QCOW2 virtual size checking for S3.#795

Merged
asfgit merged 3 commits into
apache:masterfrom
borisroman:CLOUDSTACK-8819
Sep 14, 2015
Merged

CLOUDSTACK-8819: Added QCOW2 virtual size checking for S3.#795
asfgit merged 3 commits into
apache:masterfrom
borisroman:CLOUDSTACK-8819

Conversation

@borisroman
Copy link
Copy Markdown
Contributor

@borisroman borisroman commented Sep 9, 2015

  • Cleaned up S3TemplateDownloader
  • Created static QCOW2 utils class.
  • Reformatted some parts of DownloadManagerImpl

@borisroman
Copy link
Copy Markdown
Contributor Author

borisroman commented Sep 9, 2015

Tested manually. Virtual size is correctly returned now.

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 9, 2015

cloudstack-pull-rats #558 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 9, 2015

cloudstack-pull-analysis #493 SUCCESS
This pull request looks good

wido
wido reviewed Sep 10, 2015
View reviewed changes
Comment thread utils/src/main/java/com/cloud/utils/storage/QCOW2Utils.java Outdated
Copy link
Copy Markdown
Contributor

@wido wido Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you use VIRTUALSIZE_HEADER_LENGTH here?

Copy link
Copy Markdown
Contributor Author

@borisroman borisroman Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that.

Added QCOW2 virtual size checking for S3.
1971614 
- Cleaned up S3TemplateDownloader
- Created static QCOW2 utils class.
- Reformatted some parts of DownloadManagerImpl
@asfbot
Copy link
Copy Markdown

asfbot commented Sep 10, 2015

cloudstack-pull-rats #567 ABORTED

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 10, 2015

cloudstack-pull-analysis #503 UNSTABLE
Looks like there's a problem with this pull request

@wido
Copy link
Copy Markdown
Contributor

wido commented Sep 11, 2015

LGTM

1 similar comment
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 11, 2015

LGTM

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 11, 2015

@borisroman looks good, can you increase code coverage by adding tests for the utils and core changes?

@borisroman
Copy link
Copy Markdown
Contributor Author

borisroman commented Sep 13, 2015

@bhaisaab Will do! Please wait with merging, will commit them to this PR.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 14, 2015

Thanks @borisroman

borisroman pushed a commit to borisroman/cloudstack that referenced this pull request Sep 14, 2015
Fixed Findbugs issue introduced by 1c6378e PR apache#795.
75ab81f
@borisroman
Copy link
Copy Markdown
Contributor Author

borisroman commented Sep 14, 2015

@karuturi Fixed the findbug issue. Was due to reformatting of one method.

borisroman pushed a commit to borisroman/cloudstack that referenced this pull request Sep 14, 2015
Fixed Findbugs issue introduced by 1c6378e PR apache#795.
548efca
karuturi
karuturi reviewed Sep 14, 2015
View reviewed changes
Comment thread ...secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java Outdated
Copy link
Copy Markdown
Member

@karuturi karuturi Sep 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use StringUtils.getPreferredCharset()?

@asfgit asfgit merged commit aa19a6a into apache:master Sep 14, 2015
asfgit pushed a commit that referenced this pull request Sep 14, 2015
@wido
Merge pull request #795 from borisroman/CLOUDSTACK-8819
d091b91 
CLOUDSTACK-8819: Added QCOW2 virtual size checking for S3.- Cleaned up S3TemplateDownloader
- Created static QCOW2 utils class.
- Reformatted some parts of DownloadManagerImpl

* pr/795:
  Added Unit Tests for QCOW2Utils.
  Fixed Findbugs issue introduced by 1c6378e PR #795.
  Added QCOW2 virtual size checking for S3.

Signed-off-by: Wido den Hollander <wido@widodh.nl>
borisroman pushed a commit to borisroman/cloudstack that referenced this pull request Sep 14, 2015
Fixed Findbugs issue introduced by 1c6378e PR apache#795.
dc670d5
@asfbot
Copy link
Copy Markdown

asfbot commented Sep 14, 2015

cloudstack-pull-rats #592 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 14, 2015

cloudstack-pull-rats #594 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 14, 2015

cloudstack-pull-analysis #528 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 14, 2015

cloudstack-pull-analysis #530 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 14, 2015

cloudstack-pull-analysis #531 ABORTED

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 14, 2015

cloudstack-pull-rats #595 ABORTED

@borisroman borisroman deleted the CLOUDSTACK-8819 branch September 14, 2015 17:54
asfgit pushed a commit that referenced this pull request Sep 18, 2015
@yadvr
Merge pull request #817 from borisroman/4.5
bab9938 
[4.5.3]Cherry-pick PR #795 into 4.5 branch.

* pr/817:
  Added Unit Tests for QCOW2Utils.
  Fixed Findbugs issue introduced by 1c6378e PR #795.
  Added QCOW2 virtual size checking for S3.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
kishankavala pushed a commit to kishankavala/cloudstack that referenced this pull request Oct 15, 2015
@kishankavala
Fixed Findbugs issue introduced by 1c6378e PR apache#795.
1a562d5
bvbharatk pushed a commit to bvbharatk/cloudstack that referenced this pull request Oct 19, 2015
@bvbharat
Fixed Findbugs issue introduced by 1c6378e PR apache#795.
9c06d9c
maneesha-p pushed a commit to maneesha-p/cloudstack that referenced this pull request Oct 20, 2015
Fixed Findbugs issue introduced by 1c6378e PR apache#795.
45cfe4a
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 6, 2016
@yadvr
Fixed Findbugs issue introduced by 1c6378e PR apache#795.
8a5aa0f
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@davidjumani @yadvr
Adding label for isolationmethod (#795)
b89264a 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@borisroman @asfbot @wido @yadvr @karuturi @asfgit