Skip to content

.github: disable Sonar check on forks as it requires crendential#7199

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
weizhouapache:4.18-disable-sonar-check-on-forks
Feb 13, 2023
Merged

.github: disable Sonar check on forks as it requires crendential#7199
DaanHoogland merged 1 commit into
apache:mainfrom
weizhouapache:4.18-disable-sonar-check-on-forks

Conversation

@weizhouapache

@weizhouapache weizhouapache commented Feb 13, 2023

Copy link
Copy Markdown
Member

Description

This PR disables sonar jacoco check on forks.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache mentioned this pull request Feb 13, 2023
Merged
12 tasks
@sonarqubecloud

sonarqubecloud Bot commented Feb 13, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DaanHoogland

DaanHoogland commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

@jbampton did you verify this works as expected?

@jbampton

jbampton commented Feb 13, 2023

Copy link
Copy Markdown
Member

@DaanHoogland this PR is the same as my PR that was merged today

I tested my PR when I pushed to my fork.

The Coverage Check / codecov (push) was Skipped

#7177

Also this PR works the same way as the existing workflow for docker-cloudstack-simulator.yml

cloudstack/.github/workflows/docker-cloudstack-simulator.yml

Line 37 in dcf01f7

if: github.repository == 'apache/cloudstack'

@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Feb 13, 2023
@DaanHoogland DaanHoogland merged commit ea18b86 into apache:main Feb 13, 2023
@jbampton

jbampton commented Feb 13, 2023

Copy link
Copy Markdown
Member

Seems the Sonar check still runs when you push to your fork:

https://github.com/jbampton/cloudstack

@weizhouapache weizhouapache deleted the 4.18-disable-sonar-check-on-forks branch February 14, 2023 15:58
@weizhouapache weizhouapache mentioned this pull request Oct 9, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbampton jbampton jbampton approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@yadvr yadvr Awaiting requested review from yadvr

Assignees

No one assigned

Labels

component:integration

Projects

None yet

Milestone

4.18.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@weizhouapache @DaanHoogland @jbampton