Codecov Report

Merging #7177 (fc0d009) into main (b93608e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7177   +/-   ##
=========================================
  Coverage     12.63%   12.63%           
  Complexity     8609     8609           
=========================================
  Files          2711     2711           
  Lines        255748   255748           
  Branches      39871    39871           
=========================================
  Hits          32303    32303           
  Misses       219347   219347           
  Partials       4098     4098           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

@jbampton why do we want this?
will it skip coverage checks on PRs when the fork they come from is updated?

@jbampton why do we want this? will it skip coverage checks on PRs when the fork they come from is updated?

actually there is a line in the yaml file

on: [pull_request, push]

so this check is not performed on the github forks.

However, if you push to your own repository, the check will be performed.
in this case, you need to add codecov token in your project, and codecov should work.
you can look at my repo where codecov works. @jbampton
https://github.com/weizhouapache/cloudstack-new/actions/workflows/codecov.yml
if you want to disable the checks, you can just remove them as it is your own fork/repository.

in short, I am 0 on this PR. I did not see benefit/harmless for cloudstack project.

@jbampton can you add the check on other github actions (e.g. main-sonar-check.yml, ui.yml, ci.yml) as well ?

in short, I am 0 on this PR. I did not see benefit/harmless for cloudstack project.

@jbampton can you add the check on other github actions (e.g. main-sonar-check.yml, ui.yml, ci.yml) as well ?

no worries. created a PR to follow up : #7199