CLOUDSTACK-8683: process cmd_line.json for shared network VR in cloud-early-config - #634
Closed
kishankavala wants to merge 1 commit into
Closed
CLOUDSTACK-8683: process cmd_line.json for shared network VR in cloud-early-config#634kishankavala wants to merge 1 commit into
kishankavala wants to merge 1 commit into
Conversation
Contributor
|
Awesome, @kishankavala! Will wait for the build/travis to vote/merge it. Cheers, |
|
cloudstack-pull-rats #146 SUCCESS |
|
cloudstack-pull-requests #844 UNSTABLE |
Member
|
looks good 👍 but, should this processing be part of the setup_[router|vpcrouter|dhcpserver] itself? |
Contributor
|
LGTM 👍 @karuturi, should we perhaps create an issue to follow up on this? I think we should refactor the early-config a bit and, as you mentioned, move the processing away to a more specific place. Cheers, |
Member
|
@wilderrodrigues agreed. we can take it up as a new issue |
|
cloudstack-pull-analysis #79 SUCCESS |
maneesha-p
pushed a commit
to maneesha-p/cloudstack
that referenced
this pull request
Jul 31, 2015
…-early-config This closes apache#634
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
* Removing sshKeyEnabled from template details * Hide cancel while deploying a vm * Disabling rather than showing cancel * Setting custom offerings to zero Fixes #604 Also : Hide cance button while deploying a vm Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test: