Skip to content

coverity: bring down all high impact issue in upgrade code, so we can trigger on this while reviewing#604

Merged
asfgit merged 7 commits into
apache:masterfrom
DaanHoogland:coverity-resource-leaks-upgrade
Aug 3, 2015
Merged

coverity: bring down all high impact issue in upgrade code, so we can trigger on this while reviewing#604
asfgit merged 7 commits into
apache:masterfrom
DaanHoogland:coverity-resource-leaks-upgrade

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

Assorted try-with-resource solutions to resource leaks.

 not strictly necessary in all but one case. done consequently.
@DaanHoogland DaanHoogland changed the title coverity: bring down all high impact issue so we can trigger on this while reviewing coverity: bring down all high impact issue in upgrade code, so we can trigger on this while reviewing Jul 20, 2015
@asfbot
Copy link
Copy Markdown

asfbot commented Jul 20, 2015

cloudstack-pull-rats #89 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 20, 2015

cloudstack-pull-requests #787 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 20, 2015

cloudstack-pull-rats #90 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 20, 2015

cloudstack-pull-requests #788 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 20, 2015

cloudstack-pull-analysis #22 ABORTED

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 20, 2015

cloudstack-pull-analysis #23 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 28, 2015

cloudstack-pull-rats #136 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 28, 2015

cloudstack-pull-rats #137 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 28, 2015

cloudstack-pull-requests #834 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 28, 2015

cloudstack-pull-rats #138 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 28, 2015

cloudstack-pull-requests #835 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 28, 2015

cloudstack-pull-requests #836 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 28, 2015

cloudstack-pull-analysis #69 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 28, 2015

cloudstack-pull-analysis #70 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 28, 2015

cloudstack-pull-analysis #71 ABORTED

@wilderrodrigues
Copy link
Copy Markdown
Contributor

LGTM 👍

@wido
Copy link
Copy Markdown
Contributor

wido commented Aug 3, 2015

LGTM

@asfgit asfgit merged commit 9d84d99 into apache:master Aug 3, 2015
asfgit pushed a commit that referenced this pull request Aug 3, 2015
* pr/604:
  coverity 1116563: resource count leak for accounts
  coverity 1116562: resource count resource leak
  coverity 1116612: update network cidrs firewall rules and acls
  coverity 1116610: upgrade cluster overprovisioning details
  coverity 1212194: reuse of prepared statements in try-block   and of course have them autoclosed
  coverity 1225199: vmware dc upgrade
  coverity 1288575: replace all close with try-with-resource  not strictly necessary in all but one case. done consequently.

Signed-off-by: Daan Hoogland <daan@onecht.net>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
* Removing sshKeyEnabled from template details

* Hide cancel while deploying a vm

* Disabling rather than showing cancel

* Setting custom offerings to zero

Fixes #604
Also : Hide cance button while deploying a vm

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@DaanHoogland DaanHoogland deleted the coverity-resource-leaks-upgrade branch August 16, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants