Skip to content

Router health check notification mail to show router name next to UUID #6130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvazquez merged 2 commits into from
Mar 21, 2022
Merged

Router health check notification mail to show router name next to UUID #6130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfb9a76
alerrt message altered
Mar 17, 2022
483022a
review feedback and format
Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,7 +1215,7 @@ private void handleFailingChecks(DomainRouterVO router, List<String> failingChec
return;
}

String alertMessage = "Health checks failed: " + failingChecks.size() + " failing checks on router " + router.getUuid();
String alertMessage = String.format("Health checks failed: %d failing checks on router %s / %s", failingChecks.size(), router.getName(), router.getUuid());
_alertMgr.sendAlert(AlertType.ALERT_TYPE_DOMAIN_ROUTER, router.getDataCenterId(), router.getPodIdToDeployIn(),
alertMessage, alertMessage);
s_logger.warn(alertMessage + ". Checking failed health checks to see if router needs recreate");
Comment thread
DaanHoogland marked this conversation as resolved.
Expand All @@ -1227,6 +1227,8 @@ private void handleFailingChecks(DomainRouterVO router, List<String> failingChec
String failedCheck = failingChecks.get(i);
if (i == 0) {
failingChecksEvent.append("Router ")
.append(router.getName())
.append(" / ")
.append(router.getUuid())
.append(" has failing checks: ");
}
Expand Down