Skip to content

Router health check notification mail to show router name next to UUID#6130

Merged
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:RouterNameInAlert
Mar 21, 2022
Merged

Router health check notification mail to show router name next to UUID#6130
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:RouterNameInAlert

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Mar 17, 2022

Description

This PR...

Fixes: #6129

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland DaanHoogland added this to the 4.17.0.0 milestone Mar 17, 2022
yadvr
yadvr reviewed Mar 17, 2022
View reviewed changes
Comment thread server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java Outdated
@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Mar 17, 2022

@blueorangutan package

@apache apache deleted a comment from blueorangutan Mar 17, 2022
@apache apache deleted a comment from blueorangutan Mar 17, 2022
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 17, 2022

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 17, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2916

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Mar 17, 2022

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 17, 2022

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

sureshanaparti
sureshanaparti approved these changes Mar 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 17, 2022

Trillian test result (tid-3652)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31618 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6130-t3652-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_nic Error 135.44 test_nic.py

@nvazquez nvazquez merged commit 13efa59 into apache:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr left review comments

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:virtual-router type:enhancement

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

Router health check notification mail shows UUID of router, unable to locate via UI

8 participants

@DaanHoogland @blueorangutan @yadvr @shwstppr @Pearl1594 @sureshanaparti @weizhouapache @nvazquez