Skip to content

[4.11] CLOUDSTACK-9776: extra DHCP options support with Nuage VSP#2049

Merged
fmaximus merged 1 commit into
apache:masterfrom
nuagenetworks:feature/extra_dhcp_options
Nov 21, 2017
Merged

[4.11] CLOUDSTACK-9776: extra DHCP options support with Nuage VSP#2049
fmaximus merged 1 commit into
apache:masterfrom
nuagenetworks:feature/extra_dhcp_options

Conversation

@sgoeminn
Copy link
Copy Markdown
Contributor

@sgoeminn sgoeminn commented Apr 18, 2017

@sgoeminn sgoeminn changed the title CLOUDSTACK-9776: extra DHCP options support for Nuage VSP [4.11/Future] CLOUDSTACK-9776: extra DHCP options support for Nuage VSP Apr 18, 2017
@sgoeminn sgoeminn force-pushed the feature/extra_dhcp_options branch from aa665be to 85babbb Compare April 18, 2017 09:32
@prashanthvarma
Copy link
Copy Markdown
Contributor

prashanthvarma commented Apr 18, 2017

Validation:

Added Marvin test code PEP8 and PyFlakes compliance:

CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$

Added Marvin test results:

CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_extra_dhcp.py

smoke_test (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: smoke_test | Status : SUCCESS ===
ok
test_01_nuage_extra_dhcp_single_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_01_nuage_extra_dhcp_single_nic_in_isolated_network | Status : SUCCESS ===
ok
test_02_nuage_extra_dhcp_single_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_02_nuage_extra_dhcp_single_nic_in_vpc | Status : EXCEPTION ===
ERROR
test_03_nuage_extra_dhcp_single_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_03_nuage_extra_dhcp_single_nic_in_shared_network | Status : SUCCESS ===
ok
test_04_nuage_extra_dhcp_update_vm_in_isoltated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_04_nuage_extra_dhcp_update_vm_in_isoltated_network | Status : SUCCESS ===
ok
test_05_nuage_extra_dhcp_update_vm_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_05_nuage_extra_dhcp_update_vm_in_vpc | Status : SUCCESS ===
ok
test_06_nuage_extra_dhcp_update_vm_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_06_nuage_extra_dhcp_update_vm_in_shared_network | Status : SUCCESS ===
ok
test_07_nuage_extra_dhcp_add_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_07_nuage_extra_dhcp_add_nic_in_isolated_network | Status : SUCCESS ===
ok
test_08_nuage_extra_dhcp_add_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_08_nuage_extra_dhcp_add_nic_in_vpc | Status : SUCCESS ===
ok
test_09_nuage_extra_dhcp_add_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_09_nuage_extra_dhcp_add_nic_in_shared_network | Status : SUCCESS ===
ok
test_10_nuage_extra_dhcp_deploy_multi_nic_vm_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_10_nuage_extra_dhcp_deploy_multi_nic_vm_in_isolated_network | Status : SUCCESS ===
ok
test_11_nuage_extra_dhcp_deploy_multi_nic_vm_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_11_nuage_extra_dhcp_deploy_multi_nic_vm_in_vpc | Status : SUCCESS ===
ok
test_12_nuage_extra_dhcp_deploy_multi_nic_vm_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_12_nuage_extra_dhcp_deploy_multi_nic_vm_in_shared_network | Status : SUCCESS ===
ok
test_13_nuage_extra_dhcp_update_multi_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_13_nuage_extra_dhcp_update_multi_nic_in_isolated_network | Status : SUCCESS ===
ok
test_14_nuage_extra_dhcp_update_multi_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_14_nuage_extra_dhcp_update_multi_nic_in_vpc | Status : SUCCESS ===
ok
test_15_nuage_extra_dhcp_update_multi_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_15_nuage_extra_dhcp_update_multi_nic_in_shared_network | Status : SUCCESS ===
ok
test_16_nuage_extra_dhcp_remove_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_16_nuage_extra_dhcp_remove_nic_in_isolated_network | Status : SUCCESS ===
ok
test_17_nuage_extra_dhcp_remove_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_17_nuage_extra_dhcp_remove_nic_in_vpc | Status : SUCCESS ===
ok
test_18_nuage_extra_dhcp_remove_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_18_nuage_extra_dhcp_remove_nic_in_shared_network | Status : SUCCESS ===
ok
test_19_nuage_extra_dhcp_vm_actions_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_19_nuage_extra_dhcp_vm_actions_in_isolated_network | Status : SUCCESS ===
ok
test_20_nuage_nuage_extra_dhcp_vm_actions_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_20_nuage_nuage_extra_dhcp_vm_actions_in_vpc | Status : SUCCESS ===
ok
test_21_nuage_extra_dhcp_vm_actions_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_21_nuage_extra_dhcp_vm_actions_in_shared_network | Status : SUCCESS ===
ok
test_22_nuage_extra_dhcp_network_actions_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_22_nuage_extra_dhcp_network_actions_in_isolated_network | Status : SUCCESS ===
ok
test_23_nuage_nuage_extra_dhcp_network_actions_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_23_nuage_nuage_extra_dhcp_network_actions_in_vpc | Status : SUCCESS ===
ok
test_24_nuage_extra_dhcp_network_actions_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_24_nuage_extra_dhcp_network_actions_in_shared_network | Status : SUCCESS ===
ok
test_25_nuage_extra_dhcp_nic_after_migrate_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_25_nuage_extra_dhcp_nic_after_migrate_in_isolated_network | Status : SUCCESS ===
ok
test_26_nuage_nuage_extra_dhcp_nic_after_migrate_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_26_nuage_nuage_extra_dhcp_nic_after_migrate_in_vpc | Status : SUCCESS ===
ok
test_27_nuage_extra_dhcp_nic_after_migrate_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_27_nuage_extra_dhcp_nic_after_migrate_in_shared_network | Status : SUCCESS ===
ok
test_28_nuage_extra_dhcp_deploy_multiple_vms (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_28_nuage_extra_dhcp_deploy_multiple_vms | Status : SUCCESS ===
ok
test_29_nuage_extra_dhcp_allocated_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_29_nuage_extra_dhcp_allocated_isolated_network | Status : SUCCESS ===
ok
test_30_nuage_extra_dhcp_allocated_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_30_nuage_extra_dhcp_allocated_vpc | Status : SUCCESS ===
ok
test_31_nuage_extra_dhcp_allocated_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_31_nuage_extra_dhcp_allocated_shared_network | Status : SUCCESS ===
ok
.
.
.
Ran 32 tests in 36921.991s

FAILED (errors=1)

failed_plus_exceptions.txt
results.txt
runinfo.txt

Note: Marvin test failure "test_02_nuage_extra_dhcp_single_nic_in_vpc" is a known issue, and we are investigating it.

@sgoeminn sgoeminn changed the title [4.11/Future] CLOUDSTACK-9776: extra DHCP options support for Nuage VSP [4.11/Future] CLOUDSTACK-9776: extra DHCP options support with Nuage VSP Apr 18, 2017
@prashanthvarma prashanthvarma force-pushed the feature/extra_dhcp_options branch from 85babbb to 5f6117c Compare April 20, 2017 07:41
@sgoeminn sgoeminn changed the title [4.11/Future] CLOUDSTACK-9776: extra DHCP options support with Nuage VSP [4.11] CLOUDSTACK-9776: extra DHCP options support with Nuage VSP May 12, 2017
@sgoeminn sgoeminn force-pushed the feature/extra_dhcp_options branch 4 times, most recently from 96bfe20 to adf506d Compare September 21, 2017 10:52
@sgoeminn sgoeminn force-pushed the feature/extra_dhcp_options branch from adf506d to 54bfb94 Compare September 29, 2017 07:33
@sgoeminn sgoeminn force-pushed the feature/extra_dhcp_options branch from 54bfb94 to efc6a7d Compare October 11, 2017 09:44
@sgoeminn sgoeminn force-pushed the feature/extra_dhcp_options branch from efc6a7d to 167a7a6 Compare October 26, 2017 09:58
@fmaximus fmaximus added this to the 4.11 milestone Oct 31, 2017
@fmaximus fmaximus force-pushed the feature/extra_dhcp_options branch from 167a7a6 to 573f3c7 Compare November 2, 2017 17:17
CLOUDSTACK-9776: extra DHCP options support for Nuage VSP
aec0371 
Co-Authored-By: Frank Maximus <frank.maximus@nuagenetworks.net>
Co-Authored-By: Prashanth Manthena <prashanth.manthena@nuagenetworks.net>
Co-Authored-By: Raf Smeets <raf.smeets@nuagenetworks.net>

Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-9776

Design-Doc: https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+extra+DHCP+option+support
@sgoeminn sgoeminn force-pushed the feature/extra_dhcp_options branch from 573f3c7 to aec0371 Compare November 20, 2017 14:05
@sgoeminn
Copy link
Copy Markdown
Contributor Author

sgoeminn commented Nov 20, 2017

@borisstoyanov @DaanHoogland Is it possible to run CI against this PR?

smeetsr
smeetsr approved these changes Nov 20, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@smeetsr smeetsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoke_test (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: smoke_test | Status : SUCCESS ===
ok
test_01_nuage_extra_dhcp_single_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_01_nuage_extra_dhcp_single_nic_in_isolated_network | Status : SUCCESS ===
ok
test_02_nuage_extra_dhcp_single_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_02_nuage_extra_dhcp_single_nic_in_vpc | Status : SUCCESS ===
ok
test_03_nuage_extra_dhcp_single_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_03_nuage_extra_dhcp_single_nic_in_shared_network | Status : SUCCESS ===
ok
test_04_nuage_extra_dhcp_update_vm_in_isoltated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_04_nuage_extra_dhcp_update_vm_in_isoltated_network | Status : SUCCESS ===
ok
test_05_nuage_extra_dhcp_update_vm_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_05_nuage_extra_dhcp_update_vm_in_vpc | Status : SUCCESS ===
ok
test_06_nuage_extra_dhcp_update_vm_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_06_nuage_extra_dhcp_update_vm_in_shared_network | Status : SUCCESS ===
ok
test_07_nuage_extra_dhcp_add_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_07_nuage_extra_dhcp_add_nic_in_isolated_network | Status : SUCCESS ===
ok
test_08_nuage_extra_dhcp_add_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_08_nuage_extra_dhcp_add_nic_in_vpc | Status : SUCCESS ===
ok
test_09_nuage_extra_dhcp_add_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_09_nuage_extra_dhcp_add_nic_in_shared_network | Status : SUCCESS ===
ok
test_10_nuage_extra_dhcp_deploy_multi_nic_vm_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_10_nuage_extra_dhcp_deploy_multi_nic_vm_in_isolated_network | Status : SUCCESS ===
ok
test_11_nuage_extra_dhcp_deploy_multi_nic_vm_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_11_nuage_extra_dhcp_deploy_multi_nic_vm_in_vpc | Status : SUCCESS ===
ok
test_12_nuage_extra_dhcp_deploy_multi_nic_vm_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_12_nuage_extra_dhcp_deploy_multi_nic_vm_in_shared_network | Status : SUCCESS ===
ok
test_13_nuage_extra_dhcp_update_multi_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_13_nuage_extra_dhcp_update_multi_nic_in_isolated_network | Status : SUCCESS ===
ok
test_14_nuage_extra_dhcp_update_multi_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_14_nuage_extra_dhcp_update_multi_nic_in_vpc | Status : SUCCESS ===
ok
test_15_nuage_extra_dhcp_update_multi_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_15_nuage_extra_dhcp_update_multi_nic_in_shared_network | Status : SUCCESS ===
ok
test_16_nuage_extra_dhcp_remove_nic_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_16_nuage_extra_dhcp_remove_nic_in_isolated_network | Status : SUCCESS ===
ok
test_17_nuage_extra_dhcp_remove_nic_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_17_nuage_extra_dhcp_remove_nic_in_vpc | Status : SUCCESS ===
ok
test_18_nuage_extra_dhcp_remove_nic_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_18_nuage_extra_dhcp_remove_nic_in_shared_network | Status : SUCCESS ===
ok
test_19_nuage_extra_dhcp_vm_actions_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_19_nuage_extra_dhcp_vm_actions_in_isolated_network | Status : SUCCESS ===
ok
test_20_nuage_nuage_extra_dhcp_vm_actions_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_20_nuage_nuage_extra_dhcp_vm_actions_in_vpc | Status : SUCCESS ===
ok
test_21_nuage_extra_dhcp_vm_actions_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_21_nuage_extra_dhcp_vm_actions_in_shared_network | Status : SUCCESS ===
ok
test_22_nuage_extra_dhcp_network_actions_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_22_nuage_extra_dhcp_network_actions_in_isolated_network | Status : SUCCESS ===
ok
test_23_nuage_nuage_extra_dhcp_network_actions_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_23_nuage_nuage_extra_dhcp_network_actions_in_vpc | Status : SUCCESS ===
ok
test_24_nuage_extra_dhcp_network_actions_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_24_nuage_extra_dhcp_network_actions_in_shared_network | Status : SUCCESS ===
ok
test_25_nuage_extra_dhcp_nic_after_migrate_in_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_25_nuage_extra_dhcp_nic_after_migrate_in_isolated_network | Status : SUCCESS ===
ok
test_26_nuage_nuage_extra_dhcp_nic_after_migrate_in_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_26_nuage_nuage_extra_dhcp_nic_after_migrate_in_vpc | Status : SUCCESS ===
ok
test_27_nuage_extra_dhcp_nic_after_migrate_in_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_27_nuage_extra_dhcp_nic_after_migrate_in_shared_network | Status : SUCCESS ===
ok
test_28_nuage_extra_dhcp_deploy_multiple_vms (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_28_nuage_extra_dhcp_deploy_multiple_vms |
Status : SUCCESS ===
ok
test_29_nuage_extra_dhcp_allocated_isolated_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_29_nuage_extra_dhcp_allocated_isolated_network | Status : SUCCESS ===
ok
test_30_nuage_extra_dhcp_allocated_vpc (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_30_nuage_extra_dhcp_allocated_vpc | Status : SUCCESS ===
ok
test_31_nuage_extra_dhcp_allocated_shared_network (nuagevsp.test_nuage_extra_dhcp.TestNuageExtraDhcp) ... === TestName: test_31_nuage_extra_dhcp_allocated_shared_network | Status : SUCCESS ===
ok

@borisstoyanov
Copy link
Copy Markdown
Contributor

borisstoyanov commented Nov 20, 2017

sure @sgoeminn, please keep in mind that runs the tests in smoke dir.
@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 20, 2017

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 20, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1277

@borisstoyanov
Copy link
Copy Markdown
Contributor

borisstoyanov commented Nov 20, 2017

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 20, 2017

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 21, 2017

Trillian test result (tid-1669)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30824 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2049-t1669-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 60 look OK, 3 have error(s)

Test Result Time (s) Test File
test_01_vpc_remote_access_vpn Failure 66.25 test_vpc_vpn.py
test_04_rvpc_privategw_static_routes Failure 390.00 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 213.80 test_privategw_acl.py
test_02_vpc_privategw_static_routes Failure 194.10 test_privategw_acl.py
test_01_vpc_privategw_acl Failure 71.97 test_privategw_acl.py
test_05_add_annotation_for_invalid_entityType Error 0.07 test_host_annotations.py
test_change_service_offering_for_vm_with_snapshots Skipped 0.00 test_vm_snapshots.py
test_09_copy_delete_template Skipped 0.02 test_templates.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.02 test_staticroles.py
test_11_ss_nfs_version_on_ssvm Skipped 0.02 test_ssvm.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.09 test_primary_storage.py
test_vm_nic_adapter_vmxnet3 Skipped 0.00 test_nic_adapter_type.py
test_03_nic_multiple_vmware Skipped 1.10 test_nic.py
test_nested_virtualization_vmware Skipped 0.00 test_nested_virtualization.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_list_ha_for_host_valid Skipped 0.02 test_hostha_simulator.py
test_list_ha_for_host_invalid Skipped 0.02 test_hostha_simulator.py
test_list_ha_for_host Skipped 0.03 test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider Skipped 0.03 test_hostha_simulator.py
test_hostha_enable_feature_valid Skipped 0.02 test_hostha_simulator.py
test_hostha_disable_feature_valid Skipped 0.03 test_hostha_simulator.py
test_hostha_configure_invalid_provider Skipped 0.03 test_hostha_simulator.py
test_hostha_configure_default_driver Skipped 0.03 test_hostha_simulator.py
test_ha_verify_fsm_recovering Skipped 0.03 test_hostha_simulator.py
test_ha_verify_fsm_fenced Skipped 0.06 test_hostha_simulator.py
test_ha_verify_fsm_degraded Skipped 0.03 test_hostha_simulator.py
test_ha_verify_fsm_available Skipped 0.02 test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership Skipped 0.03 test_hostha_simulator.py
test_ha_list_providers Skipped 0.02 test_hostha_simulator.py
test_ha_enable_feature_invalid Skipped 0.02 test_hostha_simulator.py
test_ha_disable_feature_invalid Skipped 0.02 test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones Skipped 0.02 test_hostha_simulator.py
test_configure_ha_provider_valid Skipped 0.02 test_hostha_simulator.py
test_configure_ha_provider_invalid Skipped 0.03 test_hostha_simulator.py
test_deploy_vgpu_enabled_vm Skipped 0.04 test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support Skipped 0.04 test_deploy_vgpu_enabled_vm.py

@smeetsr
Copy link
Copy Markdown
Contributor

smeetsr commented Nov 21, 2017

Even better results then when executed same for #1981 , so all errors are known issues. LGTM.

borisstoyanov
borisstoyanov approved these changes Nov 21, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, smoketests have passed, the errors are due to known issues, nuage plugin tests looks sufficient as well.

@fmaximus fmaximus merged commit 7786499 into apache:master Nov 21, 2017
@fmaximus fmaximus deleted the feature/extra_dhcp_options branch November 21, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmaximus fmaximus fmaximus approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

+1 more reviewer

@smeetsr smeetsr smeetsr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status:needs-CI type:enhancement

Projects

None yet

Milestone

4.11.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@sgoeminn @prashanthvarma @borisstoyanov @blueorangutan @smeetsr @fmaximus @kiwiflyer