CLOUDSTACK-9806: Nuage domain template selection per VPC#1981
Conversation
|
Design document for this feature: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Nuage+domain+template+selection+per+VPC |
|
PEP8 & PyFlakes compliance of our marvin test code: CloudStack$ Validations: Marvin test results: nosetests --with-marvin --marvin-config=nuage.cfg nuagevsp/test_nuage_vsp_domain_template.py Test Nuage VSP Domain Template selection per VPC ... === TestName: test_01_nuage_Domain_Template_selection_per_VPC | Status : SUCCESS === Ran 12 tests in 6203.613s OK |
55ce0d9 to
0e80c9b
Compare
|
Thanks for this good looking PR @prashanthvarma, it's really great that you provided integration tests. I'll package and kick regression tests to check if everything else is working fine with these changes. |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-555 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@borisstoyanov I am glad you liked the PR, we (@nuagenetworks) made it a practice to add and run integration tests that test the changes we propose/make in a PR. Moreover, we internally qualify through regressions the whole system with those changes for both Nuage VSP and native ACS setups/environments where necessary. Thank you for kicking the regression tests. Please do also code review the PR. |
|
Trillian test result (tid-923)
|
|
Thanks, the tests failures looks to be not related to these changes. @prashanthvarma |
|
@borisstoyanov yes, I also did cross check the test failures. Thanks for the investigation. |
0e80c9b to
238446f
Compare
840a3cd to
9805341
Compare
9805341 to
c3fcaf9
Compare
e333479 to
3ab9bc7
Compare
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 Failed tests:
Skipped tests: Passed test suits: |
3ab9bc7 to
dfbb369
Compare
|
@prashanthvarma can you see and fix CI failures? |
dfbb369 to
646ac45
Compare
|
@rhtyd I rebased the PR, CI failure is a know issue (test_02_project_limits_normal_user) everything else looks good. |
b1ecc10 to
ff0d915
Compare
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1192 |
| import java.util.List; | ||
|
|
||
| @APICommand(name = "listNuageVspDomainTemplates", responseObject = BaseResponse.class, description = "Lists Nuage VSP domain templates", authorized = {RoleType.Admin, RoleType.DomainAdmin, RoleType.User}) | ||
| public class ListNuageVspDomainTemplatesCmd extends BaseListCmd { |
There was a problem hiding this comment.
@prashanthvarma have a look at ListRolesCmd and other newer implemented/added API for refering to a more modern CloudStack API implementation pattern.
There was a problem hiding this comment.
@rhtyd I made it aligned with the ListRolesCmd implementation.
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1609)
|
ff0d915 to
b2bc68f
Compare
|
After above commit , again I did a rerun of test_nuage_vpc_domain_template.py and all tests were successful. Ran 12 tests in 5290.439s OK |
borisstoyanov
left a comment
There was a problem hiding this comment.
thanks @smeetsr let me run marvin tests to check for regressions
@blueorangutan package
| import org.apache.cloudstack.context.CallContext; | ||
| import org.apache.log4j.Logger; | ||
|
|
||
| import javax.inject.Inject; |
| @APICommand(name = "associateNuageVspDomainTemplate", responseObject = SuccessResponse.class, description = "associate a vpc with a domain template", authorized = {RoleType.Admin, RoleType.DomainAdmin, RoleType.User}) | ||
| public class AssociateNuageVspDomainTemplateCmd extends BaseCmd { | ||
| private static final Logger s_logger = Logger.getLogger(AssociateNuageVspDomainTemplateCmd.class.getName()); | ||
| private static final String s_name = "associatenuagevspdomaintemplateresponse"; |
There was a problem hiding this comment.
@sgoeminn this still does not declare use APINAME as a reference/usage pattern as seen in recent/modern API implementations such as ListRolesCmd etc.
| import java.util.List; | ||
| @APICommand(name = ListNuageVspDomainTemplatesCmd.APINAME, responseObject = BaseResponse.class, description = "Lists Nuage VSP domain templates", since = "4.11", responseHasSensitiveInfo = false, authorized = {RoleType.Admin, RoleType.DomainAdmin, RoleType.User}) | ||
| public class ListNuageVspDomainTemplatesCmd extends BaseCmd { | ||
| static final String APINAME = "listNuageVspDomainTemplates"; |
There was a problem hiding this comment.
@sgoeminn thanks, LGTM. Please follow the same across other Cmd implementations.
| import org.apache.cloudstack.api.response.ZoneResponse; | ||
|
|
||
| import javax.inject.Inject; | ||
| import java.util.List; |
| } | ||
|
|
||
| public Long getZoneId() { return zoneId; } | ||
| ///////////////////////////////////////////////////// |
Co-Authored-By: Prashanth Manthena <prashanth.manthena@nuagenetworks.net> Co-Authored-By: Frank Maximus <frank.maximus@nuagenetworks.net> Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-9806 Design Document: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Nuage+domain+template+selection+per+VPC
b2bc68f to
880e475
Compare
|
@rhtyd Thanks for reviewing! I addressed all your comments. |
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1262 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1656)
|
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, test show known issues
|
@fmaximus thanks for merging, kindly squash merge or rebase/merge in future. |
Co-Authored-By: Prashanth Manthena prashanth.manthena@nuagenetworks.net
Co-Authored-By: Frank Maximus frank.maximus@nuagenetworks.net