packaging: align mysql connector with Marvin - #13840
Draft
andrijapanicsb wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@blueorangutan package |
|
@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13840 +/- ##
============================================
- Coverage 17.69% 17.69% -0.01%
+ Complexity 15835 15834 -1
============================================
Files 5925 5925
Lines 533539 533539
Branches 65274 65274
============================================
- Hits 94427 94421 -6
- Misses 428435 428442 +7
+ Partials 10677 10676 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18814 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small follow-up for #13482.
In #13482 the Marvin dependency was changed to
mysql-connector-python >= 8.4.0. The older 8.0.31 connector was installed on the Marvin node and caused smoke test failures when testing against OL10, Debian 12 and SUSE15 management environments.However, the RPM specs were not updated at the same time. Current situation is:
%poststill explicitly installs 8.0.31 before it installs Marvin, while Marvin asks for 8.4.0 or newer;Management and Marvin are normally installed on different machines, so this is not a clash between two packages on the same server. Still, each RPM package should install a connector version which matches the component inside that package.
This PR changes both EL and SUSE RPM specs:
%postinstalls exact 8.4.0 before installing Marvin.I checked the current 4.23 RC branches and
main, and the same old blocks are still present there. This PR targets4.22, so it can be merged forward after that.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
How Has This Been Tested?
Tests done locally:
rpmspec -Pon Oracle Linux 8.10;pip check;Requires-Python: >=3.8metadata was verified, with cleanpip check;The upstream multi-distribution package build was also requested on this PR.