Skip to content

marvin: revert mysql-connector-python to 8.0.30#13482

Open
weizhouapache wants to merge 1 commit into
apache:4.20from
weizhouapache:4.20-revert-mysql-connector-python
Open

marvin: revert mysql-connector-python to 8.0.30#13482
weizhouapache wants to merge 1 commit into
apache:4.20from
weizhouapache:4.20-revert-mysql-connector-python

Conversation

@weizhouapache

@weizhouapache weizhouapache commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description

This PR reverts mysql-connector-python to 8.0.30

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg Bot added component:marvin Python Warning... Python code Ahead! labels Jun 24, 2026
@weizhouapache weizhouapache mentioned this pull request Jun 24, 2026
Closed
@weizhouapache weizhouapache added this to the 4.20.4 milestone Jun 24, 2026
@weizhouapache

weizhouapache commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

blueorangutan commented Jun 24, 2026

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.26%. Comparing base (2eb9820) to head (a1a8edc).

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #13482      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
+ Complexity    13436    13435       -1     
============================================
  Files          5667     5667              
  Lines        500676   500676              
  Branches      60799    60799              
============================================
- Hits          81412    81411       -1     
- Misses       410157   410158       +1     
  Partials       9107     9107
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests 17.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

blueorangutan commented Jun 24, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18361

@weizhouapache

weizhouapache commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

without the change, mysql-python-connector 8.0.31 is installed in the marvin node
which caused the smoke test failures like below, when the mgmt server is OL10, Debian12 or Suse15

Traceback (most recent call last):
  File "/marvin/tests/smoke/test_dynamicroles.py", line 653, in test_role_account_acls_multiple_mgmt_servers
    roleId = self.dbclient.execute("select id from roles where uuid='%s'" % self.role.id)[0][0]
  File "/usr/local/lib/python3.9/site-packages/marvin/dbConnection.py", line 41, in execute
    closing(mysql.connector.connect(host=str(self.host),
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/pooling.py", line 287, in connect
    return MySQLConnection(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/connection.py", line 137, in __init__
    self.connect(**kwargs)
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/abstracts.py", line 1108, in connect
    self._open_connection()
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/connection.py", line 544, in _open_connection
    self.set_converter_class(self._converter_class)
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/abstracts.py", line 1284, in set_converter_class
    self.converter = convclass(charset_name, self._use_unicode)
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/conversion.py", line 136, in __init__
    MySQLConverterBase.__init__(self, charset, use_unicode, str_fallback)
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/conversion.py", line 59, in __init__
    self.set_charset(charset)
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/conversion.py", line 73, in set_charset
    self.charset_id = CharacterSet.get_charset_info(self.charset)[0]
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/constants.py", line 775, in get_charset_info
    info = cls.get_default_collation(charset)
  File "/usr/local/lib/python3.9/site-packages/mysql/connector/constants.py", line 746, in get_default_collation
    raise ProgrammingError(f"Character set '{charset}' unsupported")
mysql.connector.errors.ProgrammingError: Character set 'utf8' unsupported

@DaanHoogland

DaanHoogland commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Jun 24, 2026

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache

weizhouapache commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan test ol10 kvm-ol10

@blueorangutan

blueorangutan commented Jun 24, 2026

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol10 mgmt + kvm-ol10) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jun 24, 2026

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-16423)

sureshanaparti
sureshanaparti approved these changes Jun 24, 2026
View reviewed changes

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sureshanaparti sureshanaparti requested a review from Copilot June 24, 2026 11:14
Copilot AI reviewed Jun 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts Marvin’s Python dependency constraints by reverting the allowed mysql-connector-python version ceiling to 8.0.30, aligning Marvin installs with an older connector version.

Changes:

  • Reverted Marvin’s mysql-connector-python upper bound from 8.4.0 to 8.0.30.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@weizhouapache weizhouapache mentioned this pull request Jun 24, 2026
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:marvin Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.20.4

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @blueorangutan @DaanHoogland @sureshanaparti