Skip to content

Make AgentConnectTaskPool core and max pool sizes configurable via global config#13552

Open
nvazquez wants to merge 1 commit into
apache:4.22from
shapeblue:422-agent-connect-task-pool-configurations
Open

Make AgentConnectTaskPool core and max pool sizes configurable via global config#13552
nvazquez wants to merge 1 commit into
apache:4.22from
shapeblue:422-agent-connect-task-pool-configurations

Conversation

@nvazquez

@nvazquez nvazquez commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

This PR replaces the hardcoded values of 100/500 in initConnectExecutor() with ConfigKeys:

  • agent.connect.executor.core.pool.size (default 100) and
  • agent.connect.executor.max.pool.size (default 500).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sachindoddaguni @nvazquez
Make AgentConnectTaskPool core and max pool sizes configurable via gl…
d5cb403 
…obal config (apache#839)

Replaces hardcoded values of 100/500 in initConnectExecutor() with ConfigKeys
agent.connect.executor.core.pool.size (default 100) and
agent.connect.executor.max.pool.size (default 500).
@nvazquez nvazquez added this to the 4.22.2 milestone Jul 6, 2026
@nvazquez

nvazquez commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 6, 2026

Copy link
Copy Markdown

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (4262c02) to head (d5cb403).

Files with missing lines Patch % Lines
...java/com/cloud/agent/manager/AgentManagerImpl.java 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.22   #13552   +/-   ##
=========================================
  Coverage     17.67%   17.67%           
  Complexity    15796    15796           
=========================================
  Files          5923     5923           
  Lines        533347   533349    +2     
  Branches      65248    65248           
=========================================
+ Hits          94253    94254    +1     
  Misses       428435   428435           
- Partials      10659    10660    +1
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.74% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

blueorangutan commented Jul 6, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18480

Damans227
Damans227 reviewed Jul 6, 2026
View reviewed changes
Comment thread engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java

private void initConnectExecutor() {
_connectExecutor = new ThreadPoolExecutor(100, 500, 60L, TimeUnit.SECONDS, new LinkedBlockingQueue<>(), new NamedThreadFactory("AgentConnectTaskPool"));
_connectExecutor = new ThreadPoolExecutor(AgentConnectExecutorCorePoolSize.value(), AgentConnectExecutorMaxPoolSize.value(), 60L, TimeUnit.SECONDS, new LinkedBlockingQueue<>(), new NamedThreadFactory("AgentConnectTaskPool"));

@Damans227 Damans227 Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no validation here? If max ends up lower than core, this throws and crashes management server startup. Maybe clamp the values before use so a bad config doesn't break things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594
@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti
@vladimirpetrov vladimirpetrov Awaiting requested review from vladimirpetrov
1 more reviewer
@Damans227 Damans227 Damans227 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:agent component:orchestration enhancement

Projects

None yet

Milestone

4.22.2

Development

Successfully merging this pull request may close these issues.

4 participants

@nvazquez @blueorangutan @Damans227 @sachindoddaguni