Skip to content

CLOUDSTACK-8851 Redundant VR getting started in the same cluster or h…#839

Merged
asfgit merged 1 commit into
apache:masterfrom
bvbharatk:CLOUDSTACK-8851
Sep 21, 2015
Merged

CLOUDSTACK-8851 Redundant VR getting started in the same cluster or h…#839
asfgit merged 1 commit into
apache:masterfrom
bvbharatk:CLOUDSTACK-8851

Conversation

@bvbharatk

@bvbharatk bvbharatk commented Sep 16, 2015

Copy link
Copy Markdown
Contributor

we are not populating the deployment destination of the previous rvr in the avoid set of the rvr that is being created. This was resulting in both the rvrs getting deployed to same host sometimes even when it
could have gone to a different one.

Now we are updating the avoids set of the deployment plan to fix this issue.

@bvbharat
CLOUDSTACK-8851 Redundant VR getting started in the same cluster or h…
7439a9b 
…ost even when there are suitable hosts available
@asfbot

asfbot commented Sep 16, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #626 SUCCESS
This pull request looks good

@asfbot

asfbot commented Sep 16, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #565 SUCCESS
This pull request looks good

@remibergsma

remibergsma commented Sep 16, 2015

Copy link
Copy Markdown
Contributor
  • Deployed Advanced zone with two KVM clusters
  • Created redundant router offering
  • Created network
  • Created VM in network

Two routers were started, each on one cluster:

MariaDB [cloud]> select name,host_id from vm_instance;
+---------+---------+
| name    | host_id |
+---------+---------+
| s-1-VM  |       1 |
| v-2-VM  |       1 |
| testvm1 |       4 |
| r-4-VM  |       4 |
| r-5-VM  |       1 |
+---------+---------+
5 rows in set (0.00 sec)

MariaDB [cloud]> select name,id,cluster_id from host;
+--------+----+------------+
| name   | id | cluster_id |
+--------+----+------------+
| kvm3   |  1 |          1 |
| v-2-VM |  2 |       NULL |
| s-1-VM |  3 |       NULL |
| kvm1   |  4 |          2 |
+--------+----+------------+
4 rows in set (0.00 sec)

MariaDB [cloud]> select id,name from cluster;
+----+------------+
| id | name       |
+----+------------+
|  2 | MCCT-KVM-1 |
|  1 | MCCT-KVM-3 |
+----+------------+
2 rows in set (0.00 sec)

Log message:

2015-09-16 13:17:49,543 DEBUG [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-3:ctx-fbf1d659 job-16/job-17 ctx-a4481789) Deploy avoids pods: null, clusters: [2], hosts: null

So, the second router (r-5-VM) avoids cluster 2 (because r-4-VM runs on host 4 which is part of cluster 2).

Seems perfectly fine: LGTM

Thanks @bvbharat

@remibergsma

remibergsma commented Sep 16, 2015

Copy link
Copy Markdown
Contributor

@karuturi Please have a look, seems like a small bug fix that can go into 4.6

@yadvr

yadvr commented Sep 18, 2015

Copy link
Copy Markdown
Member

LGTM.

@asfgit asfgit merged commit 7439a9b into apache:master Sep 21, 2015
asfgit pushed a commit that referenced this pull request Sep 21, 2015
@remibergsma
Merge pull request #839 from bvbharatk/CLOUDSTACK-8851
d543e2a 
CLOUDSTACK-8851 Redundant VR getting started in the same cluster or hwe are not populating the deployment destination of the previous rvr in the avoid set of the rvr that is being created. This was resulting in both the rvrs getting deployed to same host sometimes even when it
could have gone to a different one.

Now we are updating the avoids set of the deployment plan  to fix this issue.

* pr/839:
  CLOUDSTACK-8851 Redundant VR getting started in the same cluster or host even when there are suitable hosts available

Signed-off-by: Remi Bergsma <github@remi.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bvbharatk @asfbot @remibergsma @yadvr @asfgit @bvbharat