CLOUDSTACK-9236: Load Balancing Health Check button displayed when non-NetScaler offering is used#1338
Conversation
|
@nitin-maharana, if you create the function I suggested you to create in PR #1337, you could re-use it here. The code block 3637-3650 is the same as the one in the other PR and you are working in the same file. |
|
@rafaelweingartner : Superb I will make the modification on both PRs. Thanks. |
aec5e4e to
3787f4d
Compare
…n-NetScaler offering is used This button will be shown only when the load balancer is NetScaler. Otherwise it is hidden.
|
@nitin-maharana I like it when you put screenshots, as this speeds up my testing because I can see what you mean. I will test it soon, can you help me by putting a screenshot so that I look for the right thing? Thanks! Update: Never mind, figured it out ;-) |
|
LGTM based on these tests: Situation before when not using Netscaler:
Basically, the button is displayed but throws an ugly message. After the fix in this PR the button is hidden:
Didn't test if it shows when using Netscaler, as I don't have it in my test environment. |
|
I have some remarks about style (made one) but the logic looks fine. LGTM |
CLOUDSTACK-9236: Load Balancing Health Check button displayed when non-NetScaler offering is usedLoad balancing health check option / button should only be displayed when a NetScaler based networking offering is being used. If you try to use the health check option when NetScaler is not being used as the load balancing technology the UI throws an error stating that the health check option is not supported. This button / option should be removed from the UI if NetScaler is not included in the network offering as customers will be confused. Fix: === This button will be shown only when the load balancer is NetScaler. Otherwise it is hidden. * pr/1338: CLOUDSTACK-9236: Load Balancing Health Check button displayed when non-NetScaler offering is used Signed-off-by: Remi Bergsma <github@remi.nl>
|
Thanks @remibergsma. Sorry I saw your comments bit late. You have already figured it out. Thanks @DaanHoogland |
Load balancing health check option / button should only be displayed when a NetScaler based networking offering is being used.
If you try to use the health check option when NetScaler is not being used as the load balancing technology the UI throws an error stating that the health check option is not supported.
This button / option should be removed from the UI if NetScaler is not included in the network offering as customers will be confused.
Fix:
This button will be shown only when the load balancer is NetScaler.
Otherwise it is hidden.