CLOUDSTACK-9235: Autoscale button is missing in VPC#1337
Merged
Conversation
Member
|
Hi @nitin-maharana, The complexity of that if/else structure that you are working on is too big. I believe that you can extract the code from lines 3673-3686 to a method that returns a Boolean indicating if there is a provider named “NetScaler”. Then you could do something like : |
68ca3cb to
b02e9f0
Compare
In case of VPC, it checks the services available. If LB is there, It checks the provider is Netscaler then it shows the button or hides it.
Contributor
There was a problem hiding this comment.
You could remove the condition here, it is unnecessary
Contributor
|
Code LGTM |
asfgit
pushed a commit
that referenced
this pull request
Jan 20, 2016
CLOUDSTACK-9235: Autoscale button is missing in VPCAutoscale button is missing. This should not be the case since we are able to add NS as the external LB provider in VPC. Steps: ===== 1. Create a VPC offering with NS as the external LB provider 2. Create a VPC and configure the public tier with the above offering 3. Acquire an IP address and try to configure Load Balancing rule Result: ====== Autoscale option is not visible at all for the LB. Expected Result: ============= Autoscale option should be available and should work exactly like the way it works for a normal isolated network with NS. If we choose NS as service provider for LB, autoscale should also be visible. If VR is chosen, only then we should not display autoscale. Fix: === In case of VPC, it checks the services available. If LB is there, It checks the provider is Netscaler then it shows the button or hides it. * pr/1337: CLOUDSTACK-9235: Autoscale button is missing in VPC Signed-off-by: Remi Bergsma <github@remi.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoscale button is missing. This should not be the case since we are able to add NS as the external LB provider in VPC.
Steps:
Result:
Autoscale option is not visible at all for the LB.
Expected Result:
Autoscale option should be available and should work exactly like the way it works for a normal isolated network with NS. If we choose NS as service provider for LB, autoscale should also be visible. If VR is chosen, only then we should not display autoscale.
Fix:
In case of VPC, it checks the services available.
If LB is there, It checks the provider is Netscaler then it shows the button or hides it.