fix(tui): use path.sep for plugin name extraction in /status dialog - #46114
fix(tui): use path.sep for plugin name extraction in /status dialog#46114metal-huang wants to merge 1 commit into
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found a potentially related PR: Related PR:
Why it's related: This PR also addresses the same issue of rendering plugin names correctly in the status dialog on Windows. It appears to be an earlier attempt at fixing the file path handling issue that the current PR (46114) is addressing. The PR description mentions that prior attempts (#33375, #34183) were closed without merging, and this (#40132) might be another attempt that wasn't merged. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Note: #40132 attempts the same fix using |
Issue for this PR
Closes #46101
Type of change
What does this PR do?
On Windows,
fileURLToPath()returns backslash-separated paths, but the status dialog was splitting on/only. The entire path became a single token, and the first.in.configmade the displayed nameC:\Users\Administrator\instead ofrtk.Changed
split("/")tosplit(path.sep)and renamed the local variable to avoid shadowing thepathmodule import.How did you verify your code works?
Ran a Node script comparing old vs new logic on a Windows path:
C:\Users\Administrator\rtkScreenshots / recordings
See screenshot in linked issue #46101.
Checklist
History: This bug was reported in #34141 and two prior PRs attempted to fix it (#33375, #34183). Both were closed without merging. The bug still exists on dev, re-reported as #46101.