fix(tui): use cross-platform path splitting for local plugin names in status dialog#33375
Open
licat2023 wants to merge 3 commits into
Open
fix(tui): use cross-platform path splitting for local plugin names in status dialog#33375licat2023 wants to merge 3 commits into
licat2023 wants to merge 3 commits into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33373
Closes #16559
Type of change
What does this PR do?
On Windows,
fileURLToPath()returns paths with\separators,but the Status dialog display logic in
packages/tui/src/component/dialog-status.tsxonly splits on
/. The entire path is kept as a single string, and.split(".")[0]truncates at the.configdot, showingC:\Users\licat\instead of the plugin directory name.
This PR adds
.replace(/\\/g, "/")before the split call to normalizeWindows backslashes, so the path component extraction works on all platforms.
How did you verify your code works?
bun typecheckpasses inpackages/tui/opencode.json,opened the Status dialog, confirmed the plugin name displays its directory
basename instead of a truncated path
Screenshots / recordings
Before:
After:
Checklist