fix(tui): Prompt from stdin breaks TUI#3930
Conversation
kunaljaykam
left a comment
There was a problem hiding this comment.
thanks @veracioux it fixes the issue. i have tested in fedora
|
@kunaljaykam yw. What's missing is windows support, which I tried to add but doesn't work. I don't have a windows setup rn so I asked @rekram1-node to implement it. If you have a windows setup and are willing to help out, i think @rekram1-node would appreciate it. @rekram1-node In any case, I think this PR is good to merge since it works for linux and doesn't break anything that wasn't already broken on windows (after reverting 53dc493) |
|
i don’t have a windows setup, but you can spin up a windows instance on aws or azure and test it there using windows terminal. |
772b621 to
eb855e1
Compare
f1dc981 to
3e15a39
Compare
f8ee907 to
6a9856d
Compare
|
I tested this on window and I try doing a special case using the If some of you have any ideas, I can try and test it |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Closes #3871.
I also reverted to the behavior from
v0.15.xwhere the resulting prompt isargs.prompt + stdin, whereas inv1.xit is currentlystdin + args.prompt.