Skip to content

fix(tui): Prompt from stdin breaks TUI#3930

Closed
veracioux wants to merge 7 commits into
anomalyco:devfrom
veracioux:fix/prompt-from-stdin
Closed

fix(tui): Prompt from stdin breaks TUI#3930
veracioux wants to merge 7 commits into
anomalyco:devfrom
veracioux:fix/prompt-from-stdin

Conversation

@veracioux
Copy link
Copy Markdown
Contributor

Closes #3871.

I also reverted to the behavior from v0.15.x where the resulting prompt is args.prompt + stdin, whereas in v1.x it is currently stdin + args.prompt.

Copy link
Copy Markdown

@kunaljaykam kunaljaykam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @veracioux it fixes the issue. i have tested in fedora

@veracioux
Copy link
Copy Markdown
Contributor Author

@kunaljaykam yw. What's missing is windows support, which I tried to add but doesn't work. I don't have a windows setup rn so I asked @rekram1-node to implement it. If you have a windows setup and are willing to help out, i think @rekram1-node would appreciate it.

@rekram1-node In any case, I think this PR is good to merge since it works for linux and doesn't break anything that wasn't already broken on windows (after reverting 53dc493)

@kunaljaykam
Copy link
Copy Markdown

i don’t have a windows setup, but you can spin up a windows instance on aws or azure and test it there using windows terminal.

@krymancer
Copy link
Copy Markdown

I tested this on window and I try doing a special case using the //./con instead of /dev/tty but I got nowhere, the interfaces are different, I tried to hack and I got an state that opencode would not break but then the data wasn't going trhu at all.

If some of you have any ideas, I can try and test it

@github-actions
Copy link
Copy Markdown
Contributor

Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Stdin piping breaks UI

4 participants