fix(opencode): keep TUI interactive with piped stdin#28540
Open
LordMikkel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28538
Related to #387, #24195 and #3930.
The root cause was never addressed. This PR includes an actual fix.
Type of change
What does this PR do?
When stdin is piped, the TUI renderer was reading input from the pipe
instead of the terminal, which broke keyboard control completely,
ANSI noise, no interaction.
The run command already handled this with resolveInteractiveStdin(),
but tui was missing it. This PR applies the same fix: pass the
controlling TTY (/dev/tty on Linux, CONIN$ on Windows) to the renderer
while still consuming the piped content as the prompt.
How did you verify your code works?
Screenshots / recordings
with the PR:
without the PR (looh the issue):
Checklist