Clone and NoDrop.#411
Conversation
…he element. This could be improved upon with UI changes maintaining the source node in the source tree. Fixed the "data-nodrop" attribute. This could be improved upon with UI changes not allowing a placeholder to be placed in the destination tree. I didn't have time to add the tests. Fix issue with an Angular $watch on the tree ng-model firing twice on every drop #396 data-nodrag can be set to true or false #379 Don't force placeholder width - if you have 2 trees of different sizes the dropping elements are now the correct width #381 Corrected attribute name and fixed typos https://github.com/angular-ui-tree/angular-ui-tree/pull/410/files
|
Please merge this pull request! |
|
@meriturva thanks, but I haven't seen much action from this repo... @JimLiu any response to this PR? Thanks for all your hard work on this directive. |
|
@JimLiu what do you think to extend projects admin to others? just to restart the development and bugfix!....so thanks anyway. |
There was a problem hiding this comment.
What do you think of using data-clone-enabled? A little more verbose and in line with data-drag-enabled.
|
Thanks for the PR! 🍰 |
|
@Voles I will refacter with your comments tonight. I agree that these are consistent naming conventions with ui-tree. Thanks. |
…enabled), renamed clone->cloneEnabled (data-clone-enabled), added demo page to test the new / fixed functionality.
|
@Voles I made the changes and added a demo page for the features. Please review and test. Thanks |
|
Looks good, thanks for the updates! |
|
@Voles Thanks, please review my notes as this closes a few issues... Also I didn't version up but we should. |
Added "data-clone" element. This could be improved upon with UI changes maintaining the source node in the source tree.
Fixed the "data-nodrop" attribute. This could be improved upon with UI changes not allowing a placeholder to be placed in the destination tree.
I didn't have time to add the tests.
Fix issue with an Angular $watch on the tree ng-model firing twice on every drop: #396
data-nodrag can be set to true or false: #379
Don't force placeholder width - if you have 2 trees of different sizes the dropping elements are now the correct width: #381
Corrected attribute name and fixed typos: https://github.com/angular-ui-tree/angular-ui-tree/pull/410/files
I included other PR's as I needed all of them for my project to work together. Thanks for those who submitted the other noted PR's.