Fix issue with an Angular $watch on the tree ng-model firing twice on every drop#396
Closed
OzzieOrca wants to merge 1 commit into
Closed
Fix issue with an Angular $watch on the tree ng-model firing twice on every drop#396OzzieOrca wants to merge 1 commit into
OzzieOrca wants to merge 1 commit into
Conversation
…o the models are done as a single atomic operation
Merged
Member
|
Should be fixed by #411. @OzzieOrca can you confirm? |
Author
|
Yep this fixes it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a
$scope.$watchon the value bound to the ng-model of the tree. Every time a node is dropped, the source node is removed from its place in the model and the destination node is created causing 2 changes to the model. The watch picks up both of them.The 2 lines that cause this are:
See: https://github.com/angular-ui-tree/angular-ui-tree/blob/master/source/services/helper.js#L137-L138
Moving dragInfo.apply() into the angular scope
$applyfixes this issue. Changes to the models are now done as a single atomic operation inside the$apply.If there is a better way to fix this let me know.