This repository was archived by the owner on Sep 5, 2024. It is now read-only.
update(dialog, bottom-sheet): show warning if ng-cloak is applied on template#8856
Closed
devversion wants to merge 1 commit into
Closed
update(dialog, bottom-sheet): show warning if ng-cloak is applied on template#8856devversion wants to merge 1 commit into
devversion wants to merge 1 commit into
Conversation
…template * Once a user specifies `ng-cloak` on the template of a `md-dialog` or `md-bottom-sheet`, the opening animation will not work properly. The user / developer should be warned about that, because it's quite a common issue. References angular#8855. References angular#8854. References angular#8805. References angular#8560.
| // Once the md-bottom-sheet has `ng-cloak` applied on his template the opening animation will not work properly. | ||
| // This is a very common problem, so we have to notify the developer about this. | ||
| if (element.hasClass('ng-cloak')) { | ||
| $log.warn('$mdBottomSheet: `ng-cloak` on a md-bottom-sheet will possibly affect the opening animation.', element[0]); |
Contributor
There was a problem hiding this comment.
var message = '$mdBottomSheet: using `<md-bottom-sheet ng-cloak >` will affect the opening animations.'
$log.warn( message, element[0] );
toshiakiezaki
pushed a commit
to toshiakiezaki/angular-material
that referenced
this pull request
Jul 1, 2016
…template * Once a user specifies `ng-cloak` on the template of a `md-dialog` or `md-bottom-sheet`, the opening animation will not work properly. The user / developer should be warned about that, because it's quite a common issue. References angular#8855. References angular#8854. References angular#8805. References angular#8560. Closes angular#8856
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ng-cloakon the template of amd-dialogormd-bottom-sheet, the opening animation will not work properly.The user / developer should be warned about that, because it's quite a common issue.
References #8855. References #8854. References #8805. References #8560.