This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(bottomSheet): md-bottom-sheet open animation#8855
Closed
bradrich wants to merge 1 commit into
Closed
Conversation
devversion
added a commit
to devversion/material
that referenced
this pull request
Jun 26, 2016
…template * Once a user specifies `ng-cloak` on the template of a `md-dialog` or `md-bottom-sheet`, the opening animation will not work properly. The user / developer should be warned about that, because it's quite a common issue. References angular#8855. References angular#8854. References angular#8805. References angular#8560.
Member
|
@bradrich I've made some changes in #8856, to show a warning on the given components, if @ThomasBurleson LGTM. |
Contributor
Author
|
Thanks! I was working on that as well but fell asleep before getting it done. Almost dropped my laptop off of the bed. |
Member
|
@bradrich Oh I'm sorry. You PR just looked like its finished, so I was going to collect some ideas. |
Contributor
Author
|
Oh no, you're fine. I just sent those up as a fix and was working on the detection as a feature. I appreciate it. |
ThomasBurleson
pushed a commit
that referenced
this pull request
Jun 28, 2016
…template * Once a user specifies `ng-cloak` on the template of a `md-dialog` or `md-bottom-sheet`, the opening animation will not work properly. The user / developer should be warned about that, because it's quite a common issue. References #8855. References #8854. References #8805. References #8560. Closes #8856
toshiakiezaki
pushed a commit
to toshiakiezaki/angular-material
that referenced
this pull request
Jul 1, 2016
toshiakiezaki
pushed a commit
to toshiakiezaki/angular-material
that referenced
this pull request
Jul 1, 2016
…template * Once a user specifies `ng-cloak` on the template of a `md-dialog` or `md-bottom-sheet`, the opening animation will not work properly. The user / developer should be warned about that, because it's quite a common issue. References angular#8855. References angular#8854. References angular#8805. References angular#8560. Closes angular#8856
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8854.