fix: Normalizes SVG attributeName attribute case#31
Closed
SkyZeroZx wants to merge 1 commit into
Closed
Conversation
Corrects the casing of the `attributeName` attribute for SVG elements. The SVG DOM typically expects `attributeName` to be camelCase. This change normalizes `attributename` (lowercase) to `attributeName` when calling `setAttribute` on SVG elements, ensuring consistent and spec-compliant behavior. Includes a new test to validate this attribute name adjustment and its retrieval.
SkyZeroZx
commented
Jun 4, 2026
|
|
||
| // Set the attribute without error checking. The parser uses this. | ||
| _setAttribute: { value: function _setAttribute(qname, value) { | ||
| if (this.namespaceURI === NAMESPACE.SVG) { |
Author
There was a problem hiding this comment.
I've been reviewing the code a bit more; could we possibly add it here?
Lines 19 to 31 in a9e9e17
|
Closing as per discussion in angular/angular#69161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the casing of the
attributeNameattribute for SVG elements. The SVG DOM typically expectsattributeNameto be camelCase. This change normalizesattributename(lowercase) toattributeNamewhen callingsetAttributeon SVG elements, ensuring consistent and spec-compliant behavior.Includes a new test to validate this attribute name adjustment and its retrieval.
Fixed issue in angular/angular#69161