fix(core): validate lowercase SVG animation attribute names#69161
Open
SkyZeroZx wants to merge 1 commit into
Open
fix(core): validate lowercase SVG animation attribute names#69161SkyZeroZx wants to merge 1 commit into
SkyZeroZx wants to merge 1 commit into
Conversation
Normalize SVG animation attributeName lookup to also recognize lowercase attributename before allowing dynamic animation value bindings. Add runtime and platform-server SSR regression coverage for lowercase attributename retargeting.
69bff06 to
4535194
Compare
alan-agius4
requested changes
Jun 4, 2026
Contributor
alan-agius4
left a comment
There was a problem hiding this comment.
We should resolve this issue in Domino to maintain consistent casing behavior, given that the browser ignores case sensitivity in this context.
Contributor
Author
I'll open a PR on Domino. |
Contributor
Author
|
PR in domino angular/domino#31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize SVG animation attributeName lookup to also recognize lowercase attributename before allowing dynamic animation value bindings.
Add runtime and platform-server SSR regression coverage for lowercase attributename retargeting.
This would be similar to GHSA-jrmj-c5cx-3cw6
This only happens in SSR mode, which, despite throwing an exception on the client, doesn't actually sanitize/render the element.