fix(browserTrigger): declare msie variable#9481
Conversation
|
It might as well be removed, as far as I can tell it's never used. (See also #9478) |
|
True story. I can go and +1 your PR in a sec, but really need Angular's tests to be passing right now as I'm investigating a possible Chrome 38 bug. We might as well delete |
6d22115 to
ad1b6a0
Compare
|
Fine with me. |
The variable `msie` was used in strict mode without declaring it first, causing both jshint and the module tests to fail. This change removes it, since it was unused.
ad1b6a0 to
2e14189
Compare
abdaab7 to
30996f8
Compare
|
But this is covered by the .jshintrc file for this module no? https://github.com/angular/angular.js/blob/master/src/ngScenario/.jshintrc#L8 |
|
Yes, |
|
@petebacondarwin: the global |
|
The original problem was a missing var in front of the declaration, that caused the failure as the function is in strict mode an uninitialised variables are not allowed. (Also causes a runtime error) |
The variable
msiewas used in strict mode without declaring it first,causing both jshint and the module tests to fail. This change fixes the
problem.