This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Remove more bits and pieces of Internet Explorer 8 support#9478
Closed
realityking wants to merge 2 commits into
Closed
Remove more bits and pieces of Internet Explorer 8 support#9478realityking wants to merge 2 commits into
realityking wants to merge 2 commits into
Conversation
aed4ba6 to
23f0648
Compare
2f55e3b to
856e1fe
Compare
Contributor
There was a problem hiding this comment.
I believe it's only IE9 here, so we should call that out specifically. Unless we're trying to support Android < 4.0
Contributor
Author
There was a problem hiding this comment.
There's a workaround for Android < 4 in ngSniffer so it seems so.
c0b2547 to
10ba779
Compare
abdaab7 to
30996f8
Compare
2bfbfd6 to
2135920
Compare
2135920 to
2eeaf02
Compare
4dd5a20 to
998c61c
Compare
9bd3e89 to
02a28b0
Compare
02a28b0 to
b6bab30
Compare
b6bab30 to
5e41470
Compare
9287511 to
edf7d27
Compare
186bff9 to
3c10b80
Compare
Contributor
|
@realityking I think you opened a new PR earlier this year which removed some comments regarding IE8. Does that obsolete this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these are just comments that were explaining code removed in e843ae7. The most relevant (functional) change is the one to ngSanitize.
I've also removed adjusted some comments referring to IE8 and IE9 to only mention IE9.