Skip to content

perf(@angular/build): optimize template string size calculation in server manifest #33804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Aug 7, 2026
+9 −4
Merged

perf(@angular/build): optimize template string size calculation in server manifest #33804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/angular/build/src/utils/server-rendering/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
*/

import type { Metafile } from 'esbuild';
import { Buffer } from 'node:buffer';
import { extname } from 'node:path';
import { runInThisContext } from 'node:vm';
import { NormalizedApplicationBuildOptions } from '../../builders/application/options';
Comment thread
alan-agius4 marked this conversation as resolved.
import {
type BuildOutputFile,
Expand Down Expand Up @@ -174,9 +174,14 @@ export function generateAngularServerAppManifest(
),
);

// This is needed because JavaScript engines script parser convert `\r\n` to `\n` in template literals,
// which can result in an incorrect byte length.
const size = runInThisContext(`new TextEncoder().encode(\`${escapedContent}\`).byteLength`);
// JavaScript engine script parsers normalize `\r\n` (2 bytes in UTF-8) to `\n` (1 byte in UTF-8) in template literals.
// Subtracting the count of `\r\n` occurrences avoids allocating any temporary strings or match arrays for large assets.
let size = Buffer.byteLength(file.text);
let pos = file.text.indexOf('\r\n');
while (pos !== -1) {
size--;
pos = file.text.indexOf('\r\n', pos + 2);
}

serverAssets[file.path] =
`{size: ${size}, hash: '${file.hash}', text: () => import('./${jsChunkFilePath}').then(m => m.default)}`;
Expand Down