perf(@angular/build): optimize template string size calculation in server manifest - #33804
Merged
Merged
Conversation
alan-agius4
marked this pull request as ready for review
August 7, 2026 14:53
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
alan-agius4
force-pushed
the
perf-manifest-byte-length
branch
from
August 7, 2026 14:57
c933475 to
00d5d09
Compare
Collaborator
Author
|
/gemini review |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
alan-agius4
force-pushed
the
perf-manifest-byte-length
branch
from
August 7, 2026 15:01
00d5d09 to
6ff2f3e
Compare
Collaborator
Author
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request optimizes the server asset size calculation in the manifest generation by replacing runInThisContext with a manual calculation that subtracts \r\n occurrences from Buffer.byteLength. The review feedback suggests explicitly importing Buffer from node:buffer to maintain consistency with other Node.js built-in imports and avoid relying on the global namespace.
alan-agius4
force-pushed
the
perf-manifest-byte-length
branch
from
August 7, 2026 15:04
6ff2f3e to
52f6ab1
Compare
clydin
approved these changes
Aug 7, 2026
…rver manifest Calculates normalized byte lengths for server assets directly using Node.js Buffer.byteLength to avoid script compilation with vm.runInThisContext.
alan-agius4
force-pushed
the
perf-manifest-byte-length
branch
from
August 7, 2026 15:14
52f6ab1 to
9a069b5
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculates normalized byte lengths for server assets directly using Node.js Buffer.byteLength to avoid script compilation with vm.runInThisContext.