Skip to content

fix(docs-infra): correct select dropdown scrolling, sizing, and selec… #69394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirjs merged 1 commit into from
Jun 18, 2026
+9 −17
Merged

fix(docs-infra): correct select dropdown scrolling, sizing, and selec… #69394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions adev/shared-docs/components/select/select.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
[(value)]="selectedValues"
[multi]="false"
ngComboboxWidget
class="example-listbox"
class="docs-select-listbox"
focusMode="activedescendant"
tabindex="-1"
selectionMode="explicit"
Expand All @@ -74,12 +74,6 @@
class="docs-select-option"
>
<span class="docs-select-option-label">{{ option.label }}</span>
<span
class="material-symbols-outlined docs-select-check-icon"
translate="no"
aria-hidden="true"
>check</span
>
</div>
}
</div>
Expand Down
15 changes: 7 additions & 8 deletions adev/shared-docs/components/select/select.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,12 @@
width: 100%;
display: flex;
flex-direction: column;
}

.docs-combobox-container {
border: 1px solid var(--border-color);
border-radius: 0.25rem;
overflow: hidden;
}

.docs-select-input-container {
Expand Down Expand Up @@ -69,13 +73,16 @@

.docs-select-dialog {
position: absolute;
box-sizing: border-box;
width: 100%;
left: auto;
right: auto;
top: auto;
bottom: auto;
padding: 0;
border: 1px solid var(--border-color);
border-radius: 0.25rem;
overflow: hidden;
background-color: var(--septenary-contrast);
color: inherit;

Expand Down Expand Up @@ -178,16 +185,8 @@
color: var(--vivid-pink);
background-color: color-mix(in srgb, var(--vivid-pink) 5%, transparent);
}

&:not([aria-selected='true']) .docs-select-check-icon {
display: none;
}
}

.docs-select-option-label {
flex: 1;
}

.docs-select-check-icon {
font-size: 0.9rem;
}
3 changes: 1 addition & 2 deletions adev/shared-docs/components/select/select.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export class Select implements FormValueControl<string | null> {
readonly id = input.required<string>({alias: 'selectId'});
readonly name = input.required<string>();
readonly options = input.required<SelectOption[]>();
readonly disabled = input(false);

readonly listbox = viewChild(Listbox);
readonly combobox = viewChild(Combobox);
Expand Down Expand Up @@ -76,7 +75,7 @@ export class Select implements FormValueControl<string | null> {
const values = this.selectedValues();
if (values.length) {
this.value.set(values[0]);
//this.popupExpanded.set(false);
this.popupExpanded.set(false);
}
}

Expand Down
Loading