Skip to content

fix(docs-infra): correct select dropdown scrolling, sizing, and selec…#69394

Open
erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:docs-infra-fix-select-dropdown
Open

fix(docs-infra): correct select dropdown scrolling, sizing, and selec…#69394
erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:docs-infra-fix-select-dropdown

Conversation

@erkamyaman

Copy link
Copy Markdown
Contributor

Several issues in the shared docs Select component (used by the API reference package filter):

  • The options list never scrolled: its element used a class with no styles, so the intended max-height/overflow rule was dead. Point it at the styled class so long lists scroll within the popover.
  • Selecting an option now closes the popup instead of leaving it open.
  • Clip the trigger and popover corners (overflow: hidden) so their rounded borders render cleanly, and align the popover width with the trigger.
  • Drop the selected-option checkmark. The component is single-select and already marks the selection with a highlight, so the tick was misleading.
  • Remove the unused disabled input.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The package filter dropdown on the API reference page (the shared docs-select
component) has several issues: the options list doesn't scroll on short pages,
the popup stays open after picking an option, the trigger/popover corners and
widths don't line up, and a checkmark on the selected option makes the
single-select look like a multi-select.

Screen.Recording.2026-06-17.at.18.24.18.mov

What is the new behavior?

  • Long option lists scroll inside the popover.
  • Choosing an option closes the dropdown.
  • Trigger and popover corners are clipped and their widths match.
  • The misleading selected-option checkmark is removed (selection is shown by
    the highlight); the unused disabled input is dropped.
Screen.Recording.2026-06-17.at.18.25.27.mov

Does this PR introduce a breaking change?

  • Yes
  • No

…tion

Several issues in the shared docs `Select` component (used by the API
reference package filter):

- The options list never scrolled: its element used a class with no styles,
  so the intended max-height/overflow rule was dead. Point it at the styled
  class so long lists scroll within the popover.
- Selecting an option now closes the popup instead of leaving it open.
- Clip the trigger and popover corners (overflow: hidden) so their rounded
  borders render cleanly, and align the popover width with the trigger.
- Drop the selected-option checkmark. The component is single-select and
  already marks the selection with a highlight, so the tick was misleading.
- Remove the unused `disabled` input.
@pullapprove pullapprove Bot requested a review from crisbeto June 17, 2026 15:28
@angular-robot angular-robot Bot added the area: docs-infra Angular.dev application and infrastructure label Jun 17, 2026
@ngbot ngbot Bot added this to the Backlog milestone Jun 17, 2026
@erkamyaman

Copy link
Copy Markdown
Contributor Author

https://angular.dev/api can be seen here.

@github-actions

Copy link
Copy Markdown

Deployed adev-preview for ee60942 to: https://ng-dev-previews-fw--pr-angular-angular-69394-adev-prev-4w6pn1s5.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 17, 2026
@JeanMeche JeanMeche removed the request for review from crisbeto June 17, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants