fix(docs-infra): correct select dropdown scrolling, sizing, and selec…#69394
Open
erkamyaman wants to merge 1 commit into
Open
fix(docs-infra): correct select dropdown scrolling, sizing, and selec…#69394erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
…tion Several issues in the shared docs `Select` component (used by the API reference package filter): - The options list never scrolled: its element used a class with no styles, so the intended max-height/overflow rule was dead. Point it at the styled class so long lists scroll within the popover. - Selecting an option now closes the popup instead of leaving it open. - Clip the trigger and popover corners (overflow: hidden) so their rounded borders render cleanly, and align the popover width with the trigger. - Drop the selected-option checkmark. The component is single-select and already marks the selection with a highlight, so the tick was misleading. - Remove the unused `disabled` input.
Contributor
Author
|
https://angular.dev/api can be seen here. |
|
Deployed adev-preview for ee60942 to: https://ng-dev-previews-fw--pr-angular-angular-69394-adev-prev-4w6pn1s5.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several issues in the shared docs
Selectcomponent (used by the API reference package filter):disabledinput.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The package filter dropdown on the API reference page (the shared
docs-selectcomponent) has several issues: the options list doesn't scroll on short pages,
the popup stays open after picking an option, the trigger/popover corners and
widths don't line up, and a checkmark on the selected option makes the
single-select look like a multi-select.
Screen.Recording.2026-06-17.at.18.24.18.mov
What is the new behavior?
the highlight); the unused
disabledinput is dropped.Screen.Recording.2026-06-17.at.18.25.27.mov
Does this PR introduce a breaking change?