Skip to content

ci: configure pnpm and node setup in benchmark-compare workflow #68888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josephperrott wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

ci: configure pnpm and node setup in benchmark-compare workflow #68888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/benchmark-compare.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,18 @@ jobs:
# that the action was triggered by a team member.
ref: ${{steps.comment-branch.outputs.head_sha}}

# We cannot use `angular/dev-infra/github-actions/npm/checkout-and-setup-node` here
# because it does not support checking out from a fork (as it lacks a `repository` input).
# Thus, we checkout and setup Node/pnpm manually.
- name: Install pnpm
uses: pnpm/action-setup@903f9c1a6ebcba6cf41d87230be49611ac97822e # v6.0.3

- name: Setup Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version-file: '.nvmrc'
cache: 'pnpm'

- run: pnpm install --frozen-lockfile

- uses: angular/dev-infra/github-actions/bazel/configure-remote@442c2fcbf06a321b5196b4c5fc70e78a49242958
Expand Down
4 changes: 2 additions & 2 deletions scripts/benchmarks/index.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,14 @@ async function runCompare(bazelTargetRaw: string | undefined, compareRef: string
Log.log(green('Checking out comparison revision.'));
git.run(['checkout', 'FETCH_HEAD']);

await exec('yarn');
await exec('pnpm', ['install', '--frozen-lockfile']);
await runBenchmarkTarget(bazelTarget);
} finally {
restoreWorkingStage(git, currentRef);
}

// Re-install dependencies for `HEAD`.
await exec('yarn');
await exec('pnpm', ['install', '--frozen-lockfile']);

const comparisonResults = await collectBenchmarkResults(testlogPath);

Expand Down
Loading