Skip to content

ci: configure pnpm and node setup in benchmark-compare workflow#68888

Open
josephperrott wants to merge 1 commit into
angular:mainfrom
josephperrott:ci-fix-benchmark-compare-pnpm
Open

ci: configure pnpm and node setup in benchmark-compare workflow#68888
josephperrott wants to merge 1 commit into
angular:mainfrom
josephperrott:ci-fix-benchmark-compare-pnpm

Conversation

@josephperrott
Copy link
Copy Markdown
Member

The benchmark comparison workflow fails because it runs pnpm install without setting up node and pnpm first. We configure the setup steps manually so that checkouts from forks are supported.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 22, 2026
@josephperrott josephperrott requested a review from mattrbeck May 22, 2026 19:18
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label May 22, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 22, 2026
The benchmark comparison workflow fails because it runs pnpm install
without setting up node and pnpm first. We configure the setup steps
manually so that checkouts from forks are supported.

Additionally, we update the benchmark comparison script (index.mts)
to use pnpm rather than hardcoded yarn commands to install
dependencies when checking out revisions.
@josephperrott josephperrott force-pushed the ci-fix-benchmark-compare-pnpm branch from aefa633 to 99f6179 Compare May 22, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants