Skip to content

refactor(compiler-cli): remove deprecated MethodIdentifier from indexer #68678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erkamyaman wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −12
Open

refactor(compiler-cli): remove deprecated MethodIdentifier from indexer #68678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions packages/compiler-cli/src/ngtsc/indexer/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import {DeclarationNode} from '../../reflection';
*/
export enum IdentifierKind {
Property,
Method, // TODO: No longer being used. To be removed together with `MethodIdentifier`.
Element,
Template,
Attribute,
Expand Down Expand Up @@ -60,14 +59,6 @@ export interface PropertyIdentifier<T = DeclarationNode> extends ExpressionIdent
kind: IdentifierKind.Property;
}

/**
* Describes a method accessed in a template.
* @deprecated No longer being used. To be removed.
*/
export interface MethodIdentifier<T = DeclarationNode> extends ExpressionIdentifier<T> {
kind: IdentifierKind.Method;
}

/** Describes an element attribute in a template. */
export interface AttributeIdentifier extends TemplateIdentifier {
kind: IdentifierKind.Attribute;
Expand Down Expand Up @@ -154,7 +145,6 @@ export type TopLevelIdentifier<T = DeclarationNode> =
| TemplateNodeIdentifier<T>
| ReferenceIdentifier<T>
| VariableIdentifier
| MethodIdentifier<T>
| LetDeclarationIdentifier
| ComponentNodeIdentifier<T>
| DirectiveNodeIdentifier<T>;
Expand Down
3 changes: 1 addition & 2 deletions packages/compiler-cli/src/ngtsc/indexer/src/template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,14 @@ import {
ElementIdentifier,
IdentifierKind,
LetDeclarationIdentifier,
MethodIdentifier,
PropertyIdentifier,
ReferenceIdentifier,
TemplateNodeIdentifier,
TopLevelIdentifier,
VariableIdentifier,
} from './api';

type ExpressionIdentifier<T = DeclarationNode> = PropertyIdentifier<T> | MethodIdentifier<T>;
type ExpressionIdentifier<T = DeclarationNode> = PropertyIdentifier<T>;
type TmplTarget = TmplAstReference | TmplAstVariable | TmplAstLetDeclaration;
type TargetIdentifier<T = DeclarationNode> =
| ReferenceIdentifier<T>
Expand Down
Loading