Skip to content

refactor(compiler-cli): remove deprecated MethodIdentifier from indexer#68678

Open
erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:refactor-compiler-cli-remove-method-identifier
Open

refactor(compiler-cli): remove deprecated MethodIdentifier from indexer#68678
erkamyaman wants to merge 1 commit into
angular:mainfrom
erkamyaman:refactor-compiler-cli-remove-method-identifier

Conversation

@erkamyaman
Copy link
Copy Markdown
Contributor

The MethodIdentifier interface and the IdentifierKind.Method enum value in the indexer API were already marked as deprecated with "no longer being used, to be removed" notes. Nothing in the repo constructs a MethodIdentifier or narrows on IdentifierKind.Method, including the language service and devtools, so the types are dead and can go.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

packages/compiler-cli/src/ngtsc/indexer/src/api.ts exports a MethodIdentifier interface and an IdentifierKind.Method enum value, both annotated as deprecated with "no longer being used, to be removed" notes. Nothing in the repository constructs a MethodIdentifier, narrows on IdentifierKind.Method, or otherwise depends on either. The language service and devtools also don't reference them.

What is the new behavior?

The deprecated enum value, interface, and the MethodIdentifier<T> arm of the TopLevelIdentifier union are removed. The dead import and type-alias reference in template.ts are cleaned up to match. Verified locally with tsc --noEmit -p packages/compiler-cli/tsconfig.json (clean).

Does this PR introduce a breaking change?

  • Yes
  • No

The MethodIdentifier interface and the IdentifierKind.Method enum value
in the indexer API were already marked as deprecated with "no longer
being used, to be removed" notes. Nothing in the repo constructs a
MethodIdentifier or narrows on IdentifierKind.Method, including the
language service and devtools, so the types are dead and can go.
@pullapprove pullapprove Bot requested a review from devversion May 11, 2026 20:35
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label May 11, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: compiler Issues related to `ngc`, Angular's template compiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant