chore(async): Refactor EventEmitter and Async Facade#4893
Conversation
240dfc3 to
89a3fc8
Compare
2a2b667 to
671721e
Compare
|
cc @jeffbcross per our discussions |
There was a problem hiding this comment.
Nit: maybe move closer to the import?
|
I think the specific |
|
Dart just needs an Rx library of it's own, IMO. You could even transpile the TypeScript from RxJS 5 over directly. |
May be https://github.com/frankpepermans/rxdart can help short term ? |
|
@vicb that library looks like it's wrapping an older version of RxJS and exposing it in Dart. From my conversations with @IgorMinar, I think that the Angular team has the means to transpile TypeScript to Dart directly. Given that RxJS 5 is written entirely in TypeScript, and really isn't using any exotic JavaScript types, I think that it could be transpiled directly to Dart as well. |
6c58cb2 to
d27d7af
Compare
41916e1 to
3a8b8ee
Compare
|
@robwormald, can we get this green and merged. |
Refactor EventEmitter and Async Facade to match ES7 Observable semantics, properly use RxJS typedefs, make EventEmitter inherit from RxJS Subject. Closes angular#4149. BREAKING CHANGE: - consumers of EventEmitter no longer need to call .toRx() - EventEmitter is now generic and requires a type - e.g. `EventEmitter<string>` - EventEmitter and Observable now use the `.subscribe(generatorOrNext, error, complete)` method instead of `.observer(generator)` - ObservableWrapper uses `callNext/callError/callComplete` instead of `callNext/callThrow/callReturn`
Makes ObservableWrapper and AsyncPipe work with Observable, Subject, and EventEmitter
- EventEmitter is now generic and requires a type [angular/angular#4893] - EventEmitter and Observable now use the .subscribe(generatorOrNext, error, complete) method instead of .observer(generator) [angular/angular/pull/4893] - tsconfig: set `moduleResolution: node` - angular/angular#5248 - imports: switch to file-relative paths
- npm: update dependencies - AuthService, TaskStore: EventEmitter is now generic and requires a type [angular/angular#4893] - AuthService, TaskStore: EventEmitter and Observable now use the .subscribe(generatorOrNext, error, complete) method instead of .observer(generator) [angular/angular/pull/4893] - tsconfig: set `moduleResolution: node` [angular/angular#5248] - imports: switch to file-relative paths - docs: update readme
- npm: update dependencies - AuthService, TaskStore: EventEmitter is now generic and requires a type [angular/angular#4893] - AuthService, TaskStore: EventEmitter and Observable now use the .subscribe(generatorOrNext, error, complete) method instead of .observer(generator) [angular/angular/pull/4893] - tsconfig: set `moduleResolution: node` [angular/angular#5248] - imports: switch to file-relative paths - docs: update readme
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Refactor EventEmitter and Async Facade to match ES7 Observable semantics, properly use RxJS typedefs, make EventEmitter inherit from RxJS Subject. Closes #4149.
BREAKING CHANGE:
EventEmitter<string>.subscribe(generatorOrNext, error, complete)method instead of.observer(generator)callNext/callError/callCompleteinstead ofcallNext/callThrow/callReturnNotes: