WIP - refactor(core): refactor EventEmitter#4604
Closed
robwormald wants to merge 1 commit into
Closed
Conversation
d56c972 to
7beabfa
Compare
Contributor
There was a problem hiding this comment.
The comment can be removed now.
7beabfa to
f48ec33
Compare
Contributor
This was referenced Oct 10, 2015
56e40ca to
751452d
Compare
Contributor
There was a problem hiding this comment.
Why not use Subject directly, so changes can return Observable<T>? Or use generic EventEmitter.
2eef5f1 to
72d289c
Compare
Contributor
Author
|
blocked by #4704 |
72d289c to
00ebb3b
Compare
451230f to
586ea83
Compare
586ea83 to
6390131
Compare
Contributor
Author
|
killing this as its wildly diverged in favor of #4893 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.