docs: update `TRIAGE_AND_LABELS.md` by gkalpak · Pull Request #30171 · angular/angular

gkalpak · 2019-04-27T12:29:39Z

Add info about who adds/removes some PR labels.
Document missing labels: PR action: review, PR action: rerun CI at HEAD

IgorMinar · 2019-04-28T06:39:25Z

the bot should remove it automatically - @ocombe I don't think that this is the case right now. Could we change the bot to remove the label after the CI is kicked off? thanks!

hmm.. actually adding the label doesn't seem to trigger the CI restart right now. is there a bug somewhere?

The firebase config wasn't updated when the PR was merged. I cleaned it, it removes it now

IgorMinar

the rest looks reasonable to me, but I'll wait for others to chime in as well.

IgorMinar · 2019-04-28T06:42:39Z

Suggested change

* _**Who adds it:** @googlebot._

* _**Who adds it:** @googlebot, or a Googler manually overriding the status in case the bot got it wrong._

IgorMinar · 2019-04-28T06:43:43Z

keep in mind that only org members can add labels to PRs, so "Anybody" is misleading.

I'd use a "team member"

IgorMinar

the rest looks good to me.

IgorMinar · 2019-05-17T20:40:47Z

unnecessary line break

…_LABELS.md` Related to angular#29098.

…BELS.md`

…AGE_AND_LABELS.md`

filipesilva · 2019-05-19T14:00:49Z

+  * _**Who adds it:** Typically the PR author._
+  * _**Who removes it:** Whoever added it._
+* `PR action: review` (optional): One or more reviews are pending. The label is optional, since the review status can be derived from GitHub's Reviewers interface.
+  * _**Who adds it:** Any team member. The caretaker can use it to differentiate PRs pending review from merge-ready PRs._


I feel this label is in a bad place. It's optional, somewhat redundant, anyone can add it, and at least 2 people are responsible for removing it. And yet it signals that there's still work (reviews) to be done, and shouldn't be merged.

I think the end result is that the label is ignored. The PR author might not know that someone added it. The reviewers might not bother to see if they are the last one and remove it. It can just stay there without anyone removing it indefinitely.

So what should the caretaker do? If they are to use their best judgement and validate it against the GH reviewers interface, what's the point of it to begin with? Might as well do without that redundant chore. If they are to respect it, then the PR author can find their PR sitting there with all reviews just because someone else decided to add the label at some point.

IMHO this label needs to be stricter or be done away with. I tend towards removing it.

One benefit of this label is that it is not possible to filter the PR list view based on whether all the reviews have been approved.

FWIW, I agree with @filipesilva. If there is no way for the caretaker to filter based on PRs pending reviews, we should come up with another way that can be better automated.

In any case, this PR was specifically about documenting what the label is currently used for, so 🤷‍♂

#30171) PR Close #30171

…_LABELS.md` (#30171) Related to #29098. PR Close #30171

#30171) PR Close #30171

…_LABELS.md` (#30171) Related to #29098. PR Close #30171

angular-automatic-lock-bot · 2019-09-15T02:52:10Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

gkalpak requested a review from IgorMinar as a code owner April 27, 2019 12:29

googlebot added the cla: yes label Apr 27, 2019

gkalpak mentioned this pull request Apr 27, 2019

chore: enable github bot CI rerun feature #29098

Closed

12 tasks

gkalpak added comp: docs effort1: hours action: discuss target: patch This PR is targeted for the next patch release risk: low labels Apr 27, 2019

ngbot Bot modified the milestone: needsTriage Apr 27, 2019

gkalpak force-pushed the docs-update-labels branch 2 times, most recently from 1694f02 to 6d49d4d Compare April 27, 2019 13:15

IgorMinar reviewed Apr 28, 2019

View reviewed changes

IgorMinar added PR action: rerun CI at HEAD and removed PR action: rerun CI at HEAD labels Apr 28, 2019

IgorMinar reviewed Apr 28, 2019

View reviewed changes

ocombe added the PR action: rerun CI at HEAD label Apr 29, 2019

ngbot Bot removed the PR action: rerun CI at HEAD label Apr 29, 2019

gkalpak force-pushed the docs-update-labels branch from 6d49d4d to e651869 Compare May 1, 2019 00:35

IgorMinar approved these changes May 17, 2019

View reviewed changes

Comment thread docs/TRIAGE_AND_LABELS.md Outdated

IgorMinar May 17, 2019

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary line break

gkalpak added 7 commits May 18, 2019 00:20

docs: add info about who adds/removes labels in TRIAGE_AND_LABELS.md

701a39b

docs: document the PR action: review label in TRIAGE_AND_LABELS.md

ce6cdd9

docs: document the PR action: rerun CI at HEAD label in `TRIAGE_AND…

b27855b

…_LABELS.md` Related to angular#29098.

fixup! docs: add info about who adds/removes labels in `TRIAGE_AND_LA…

62f1b54

…BELS.md`

fixup! docs: document the PR action: review label in `TRIAGE_AND_LA…

65f73f3

…BELS.md`

fixup! docs: document the PR action: rerun CI at HEAD label in `TRI…

e623e6a

…AGE_AND_LABELS.md`

fixup! docs: document the PR action: rerun CI at HEAD label in `TRI…

3c6fdbf

…AGE_AND_LABELS.md`

gkalpak force-pushed the docs-update-labels branch from e651869 to 3c6fdbf Compare May 17, 2019 21:21

petebacondarwin approved these changes May 18, 2019

View reviewed changes

filipesilva approved these changes May 19, 2019

View reviewed changes

gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: discuss labels May 21, 2019

jasonaden closed this in 8c00fce May 21, 2019

jasonaden pushed a commit that referenced this pull request May 21, 2019

docs: document the PR action: review label in TRIAGE_AND_LABELS.md (

53a0b26

#30171) PR Close #30171

jasonaden pushed a commit that referenced this pull request May 21, 2019

docs: document the PR action: rerun CI at HEAD label in `TRIAGE_AND…

697046c

…_LABELS.md` (#30171) Related to #29098. PR Close #30171

jasonaden pushed a commit that referenced this pull request May 21, 2019

docs: add info about who adds/removes labels in TRIAGE_AND_LABELS.md (

8d1f993

#30171) PR Close #30171

jasonaden pushed a commit that referenced this pull request May 21, 2019

docs: document the PR action: review label in TRIAGE_AND_LABELS.md (

e4cc139

#30171) PR Close #30171

jasonaden pushed a commit that referenced this pull request May 21, 2019

docs: document the PR action: rerun CI at HEAD label in `TRIAGE_AND…

0e90a42

…_LABELS.md` (#30171) Related to #29098. PR Close #30171

gkalpak deleted the docs-update-labels branch May 21, 2019 20:11

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019

	* _Who adds it: @googlebot._
	* _Who adds it: @googlebot, or a Googler manually overriding the status in case the bot got it wrong._

Conversation

gkalpak commented Apr 27, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

IgorMinar Apr 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

IgorMinar Apr 28, 2019 •

edited

Loading