chore: enable github bot CI rerun feature by josephperrott · Pull Request #29098 · angular/angular

josephperrott · 2019-03-04T15:35:29Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

brandonroberts · 2019-03-04T16:08:43Z

Will there be a trigger to only re-run failed jobs?

gkalpak · 2019-03-04T17:40:11Z

What does the at HEAD mean? How is it different than Rerun CI?

@IgorMinar wanted the label to reflect that the CI will run at the current HEAD of the targeted branch being merged into, usually master.

All our CI runs at the HEAD of its target branch though:

angular/.circleci/config.yml

Lines 66 to 79 in 5b134ca

# After checkout, rebase on top of target branch.

var_7: &post_checkout

run:

name: Rebase PR on target branch

command: >

if [[ -n "${CIRCLE_PR_NUMBER}" ]]; then

# User is required for rebase.

git config user.name "angular-ci"

git config user.email "angular-ci"

# Rebase PR on top of target branch.

node tools/rebase-pr.js angular/angular ${CIRCLE_PR_NUMBER}

else

echo "This build is not over a PR, nothing to do."

fi

josephperrott · 2019-03-04T22:02:46Z

@brandonroberts the plan is to add this in the future, but the functionality for it will need to be added to the github robot first.

googlebot · 2019-04-26T17:43:02Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-04-26T17:43:34Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-04-26T17:44:43Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-04-26T17:44:51Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

gkalpak · 2019-04-27T11:13:51Z

+  # set to true to disable
+  disabled: false
+  # the label which when added triggers a rerun of the default CircleCI workflow
+  triggerRerunLabel: "PR action: rerun CI at HEAD"


🤔 PR action: labels usually indicate that someone needs to do something. PR action: rerun CI at HEAD sounds like someone needs to do it (vs it is done automatically for us).

Also, this label is not documented in docs/TRIAGE_AND_LABELS.md 😞

For reference: Documented it in #30171.

…_LABELS.md` Related to angular#29098.

PR Close angular#29098

…_LABELS.md` (#30171) Related to #29098. PR Close #30171

angular-automatic-lock-bot · 2019-09-15T00:52:04Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

josephperrott requested review from a team, IgorMinar and ocombe March 4, 2019 15:35

googlebot added the cla: yes label Mar 4, 2019

ocombe approved these changes Mar 4, 2019

View reviewed changes

gkalpak reviewed Mar 4, 2019

View reviewed changes

kara added the area: build & ci Related the build and CI infrastructure of the project label Mar 6, 2019

ngbot Bot added this to the needsTriage milestone Mar 6, 2019

josephperrott force-pushed the rerun-circle branch from 16b93b2 to eb90113 Compare March 7, 2019 17:58

josephperrott added the target: major This PR is targeted for the next major release label Mar 7, 2019

IgorMinar approved these changes Apr 26, 2019

View reviewed changes

IgorMinar added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed target: major This PR is targeted for the next major release labels Apr 26, 2019

AndrewKushnir added the hotlist: release-blocker label Apr 26, 2019

googlebot added cla: no and removed cla: yes labels Apr 26, 2019

AndrewKushnir added cla: yes and removed cla: no labels Apr 26, 2019

josephperrott and others added 2 commits April 26, 2019 10:44

ci: enable github bot CI rerun feature

a09255c

fixup! ci: enable github bot CI rerun feature

a09bcf4

IgorMinar force-pushed the rerun-circle branch from 35ef647 to a09bcf4 Compare April 26, 2019 17:44

googlebot added cla: no and removed cla: yes labels Apr 26, 2019

IgorMinar removed the cla: no label Apr 26, 2019

IgorMinar added the cla: yes label Apr 26, 2019

AndrewKushnir closed this in f45684f Apr 26, 2019

gkalpak reviewed Apr 27, 2019

View reviewed changes

gkalpak added a commit to gkalpak/angular that referenced this pull request May 17, 2019

docs: document the PR action: rerun CI at HEAD label in `TRIAGE_AND…

b27855b

…_LABELS.md` Related to angular#29098.

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

ci: enable github bot CI rerun feature (angular#29098)

b0b8e70

PR Close angular#29098

jasonaden pushed a commit that referenced this pull request May 21, 2019

docs: document the PR action: rerun CI at HEAD label in `TRIAGE_AND…

697046c

…_LABELS.md` (#30171) Related to #29098. PR Close #30171

jasonaden pushed a commit that referenced this pull request May 21, 2019

docs: document the PR action: rerun CI at HEAD label in `TRIAGE_AND…

0e90a42

…_LABELS.md` (#30171) Related to #29098. PR Close #30171

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: enable github bot CI rerun feature#29098

chore: enable github bot CI rerun feature#29098
josephperrott wants to merge 2 commits into
angular:masterfrom
josephperrott:rerun-circle

josephperrott commented Mar 4, 2019

Uh oh!

brandonroberts commented Mar 4, 2019

Uh oh!

gkalpak Mar 4, 2019

Uh oh!

josephperrott Mar 4, 2019

Uh oh!

filipesilva Apr 26, 2019

Uh oh!

josephperrott commented Mar 4, 2019

Uh oh!

googlebot commented Apr 26, 2019

Uh oh!

googlebot commented Apr 26, 2019

Uh oh!

googlebot commented Apr 26, 2019

Uh oh!

googlebot commented Apr 26, 2019

Uh oh!

gkalpak Apr 27, 2019

Uh oh!

gkalpak Apr 27, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Sep 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

	# After checkout, rebase on top of target branch.
	var_7: &post_checkout
	run:
	name: Rebase PR on target branch
	command: >
	if [[ -n "${CIRCLE_PR_NUMBER}" ]]; then
	# User is required for rebase.
	git config user.name "angular-ci"
	git config user.email "angular-ci"
	# Rebase PR on top of target branch.
	node tools/rebase-pr.js angular/angular ${CIRCLE_PR_NUMBER}
	else
	echo "This build is not over a PR, nothing to do."
	fi

Conversation

josephperrott commented Mar 4, 2019

PR Checklist

PR Type

Uh oh!

brandonroberts commented Mar 4, 2019

Uh oh!

gkalpak Mar 4, 2019

Choose a reason for hiding this comment

Uh oh!

josephperrott Mar 4, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Apr 26, 2019

Choose a reason for hiding this comment

Uh oh!

josephperrott commented Mar 4, 2019

Uh oh!

googlebot commented Apr 26, 2019

Uh oh!

googlebot commented Apr 26, 2019

Uh oh!

googlebot commented Apr 26, 2019

Uh oh!

googlebot commented Apr 26, 2019

Uh oh!

gkalpak Apr 27, 2019

Choose a reason for hiding this comment

Uh oh!

gkalpak Apr 27, 2019

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants