Skip to content

fix(forms): export collection of form directives as const in Dart#1648

Closed
pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:dart_directives_const
Closed

fix(forms): export collection of form directives as const in Dart#1648
pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:dart_directives_const

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

Fixes #1283

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename to formDirectives? needs lower case.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle Can't we have an annotation in ts2dart which would tell the ts2dart to generate const?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we resolve that question in #1524 instead of forking the discussion?

@mhevery mhevery added this to the M9: Fixit milestone May 5, 2015
@naomiblack
Copy link
Copy Markdown
Contributor

@mhevery @alexeagle @mprobst this is blocked because we need a decision on on how to transpile the const keyword in Dart. Assigning to M8 since it is blocking #1283 in M8.

See some discussion of the issue in #1524

@naomiblack naomiblack modified the milestones: M8: GT Customer (non-blocking), M9: Fixit May 8, 2015
@mprobst
Copy link
Copy Markdown
Contributor

mprobst commented May 8, 2015

I think the magic const function is the best idea, thanks Tobias. I'll TAL
at implementing this.

Naomi Black notifications@github.com schrieb am Fr., 8. Mai 2015 08:46:

@mhevery https://github.com/mhevery @alexeagle
https://github.com/alexeagle @mprobst https://github.com/mprobst this
is blocked because we need a decision on on how to transpile the const
keyword in Dart. Assigning to M8 since it is blocking #1283
#1283 in M8.

See some discussion of the issue in #1524
#1524


Reply to this email directly or view it on GitHub
#1648 (comment).

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented May 8, 2015

Closing due to: dart-archive/ts2dart@2e02103

@mhevery mhevery closed this May 8, 2015
@pkozlowski-opensource pkozlowski-opensource deleted the dart_directives_const branch July 20, 2015 12:55
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FormDirectives should be const in Dart

7 participants