Skip to content

FormDirectives should be const in Dart #1283

Closed

Description

@kwalrath

When using forms, you should be able to say this:

directives: const[FormDirectives, If]

But FormDirectives isn't a const, so you need a workaround like this:

directives: const[
  const[ //XXX: workaround for FormDirectives not being const.
    ControlGroupDirective,
    ControlDirective,
    CheckboxControlValueAccessor,
    DefaultValueAccessor],
  If]

Activity

  1. changed the title [-]FormDirectives should be const[/-] [+]FormDirectives should be const in Dart[/+] on Apr 9, 2015
  2. added a commit that references this issue on Apr 29, 2015
    671d676
  3. added 3 commits that reference this issue on May 2, 2015
    32d7b94
    85d7b18
    480d4d1
  4. naomiblack commented on May 8, 2015

    @naomiblack
    Contributor

    @mhevery I think this is closed now? Can you confirm?

  5. pkozlowski-opensource commented on May 8, 2015

    @pkozlowski-opensource
    Member

    Nope, there is a PR for this but its review is blocked on the decision on how to transpire const in Dart.

  6. naomiblack commented on May 8, 2015

    @naomiblack
    Contributor

    This is blocked on #1648

  7. mhevery commented on May 8, 2015

    @mhevery
    Contributor

    Unblocked: dart-archive/ts2dart@2e02103 and @pkozlowski-opensource is working on merging it in.

  8. added a commit that references this issue on May 11, 2015
    bf77c39
  9. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  10. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions