Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
3602b95
Bump tar-fs from 3.0.9 to 3.1.1
dependabot[bot] Sep 24, 2025
1b510fc
Merge pull request #686 from ableplayer/dependabot/npm_and_yarn/tar-f…
joedolson Sep 26, 2025
45a54b1
Merge pull request #687 from ableplayer/develop
joedolson Sep 26, 2025
562b6b5
Merge pull request #688 from ableplayer/develop
joedolson Sep 28, 2025
2cb553f
#692 Parse timestamp tags in WebVTT
richard-smith-preservica Oct 16, 2025
48a8655
Setting max-width does not set width; need video to default to 100%
joedolson Oct 24, 2025
37b976b
Merge pull request #693 from richard-smith-preservica/timestamp-tags-…
joedolson Dec 20, 2025
1e8cb26
Hide transcript & description preferences if player does not have those
joedolson Dec 20, 2025
ca9dec7
Remove console.log
joedolson Dec 20, 2025
8db667f
Prevent descriptions from firing when media not playing
joedolson Dec 20, 2025
4f11091
Avoid repainting icons when unchanged
joedolson Dec 27, 2025
c3cd4b8
Add a new method to fetch translations, with support for fallback.
joedolson Dec 28, 2025
a29b72d
Apply big play on background and background color.
joedolson Dec 28, 2025
78948a2
Make Cookie.js an optional dependency, and use localStorage by default
joedolson Dec 28, 2025
1d14cbf
Remove screen reader only text from buttons
joedolson Dec 28, 2025
4be3ec9
Big play button shouldn't have border radius
joedolson Dec 28, 2025
a917047
Add mechanism to view translations in demos
joedolson Dec 28, 2025
3c2cac4
Remove JS sizing to define player width and height
joedolson Dec 28, 2025
33758cf
Make player type aria-label a translatable string
joedolson Dec 28, 2025
2586e95
Add support for an audio poster image.
joedolson Dec 28, 2025
e082170
Add poster image demo to index
joedolson Dec 28, 2025
fb48cbd
Invite people to contribute financially to Able Player
joedolson Dec 28, 2025
bbf5c65
Add support link to docs header.
joedolson Dec 28, 2025
c94be4a
Update funding info to be current.
joedolson Dec 28, 2025
1dc4515
Move API docs to a notes file in docs instead of JS files.
joedolson Dec 28, 2025
3437d38
Add docs about array elements in geticons
joedolson Dec 28, 2025
5f7b138
Add support for a fixed location for sign language video
joedolson Dec 28, 2025
dd8689d
Update package-lock.json
joedolson Dec 28, 2025
f63c909
Adjust caption styling to center.
joedolson Dec 28, 2025
b2582e2
Rename vars to reflect that they may not be cookies
joedolson Dec 29, 2025
a693ef9
More cookie var renaming
joedolson Dec 29, 2025
9e30126
Improve draggable window positioning
joedolson Dec 29, 2025
596c617
Replace $.ajax with fetch in tracks
joedolson Dec 29, 2025
0a2011c
Begin process of removing jQuery by supporting jQuery slim
joedolson Dec 29, 2025
fd00c08
Update fadeout/in to use CSS transitions
joedolson Dec 29, 2025
8e46268
Update comments to reflect change
joedolson Dec 29, 2025
ffef8fa
Change translations to fetch async await
joedolson Dec 29, 2025
eb816bb
Show needs to happen before hide, not simultaneous.
joedolson Dec 29, 2025
493c21f
Swap jQuery deferred to custom prototype
joedolson Dec 30, 2025
1678dd6
Update docs to reflect changed dependency & update demos to use the s…
joedolson Dec 30, 2025
2b33a4c
Missed file save in deferred changes
joedolson Dec 30, 2025
4d4f887
Eliminate some unused code
joedolson Dec 30, 2025
ac831d7
Merge pull request #709 from ableplayer/jquery-slim
joedolson Dec 30, 2025
fa3ae30
Replace jQuery getScript
joedolson Dec 30, 2025
4d3fd84
On Safari, YouTube automatic posters don't show. This is a known Safa…
joedolson Dec 30, 2025
b92a105
Merge pull request #711 from ableplayer/jquery-slim
joedolson Dec 30, 2025
9cee3c8
Remove some additional unused variables.
joedolson Dec 30, 2025
360b5eb
Merge branch 'develop' of https://github.com/ableplayer/ableplayer in…
joedolson Dec 30, 2025
61c9277
Function doesn't use the YouTube ID argument.
joedolson Dec 30, 2025
7c95772
Remove hide callbacks & change draggable to be a more explicit region.
joedolson Dec 30, 2025
d75d394
Design adjustments to resize and drag handles
joedolson Dec 30, 2025
35f3dd8
Unused var
joedolson Dec 30, 2025
f366acf
Set transcript language order; design adjustments.
joedolson Dec 30, 2025
8b6bcaa
Invalid value passed to getYouTubePosterUrl
joedolson Dec 31, 2025
edda545
All YouTube videos have 640, not all have hd.
joedolson Dec 31, 2025
661ccfb
Assign poster as background to bigplaybutton
joedolson Dec 31, 2025
b2641d2
Remove code that enables poster with YouTube player
joedolson Dec 31, 2025
0214f1f
Remove unused variable, minor changes to comments
joedolson Dec 31, 2025
4127407
Remove setFullscreen(false) when rebuilding player
joedolson Dec 31, 2025
c7c6d7f
Remove references to the helpDialog, which hasn't existed for at leas…
joedolson Dec 31, 2025
3847046
Add preference enabling users to disable custom keyboard shortcuts
joedolson Dec 31, 2025
de99c87
Set border-box sizing on chapters buttons
joedolson Dec 31, 2025
5157e44
Add setTimeout to resolve promise if no captions found.
joedolson Dec 31, 2025
3b5ef73
Simplify AccessibleDialog, remove fullscreen polyfill
joedolson Dec 31, 2025
cb17466
Adjust and restore sign and transcript windows for fullscreen
joedolson Dec 31, 2025
733e64f
Remove right margin on checkbox label in draggables
joedolson Jan 1, 2026
d6dc0c3
Update VTT parsing to handle cues as individual inputs.
joedolson Jan 9, 2026
7228330
Remove debugging
joedolson Jan 9, 2026
c71301c
Ensure that positioning $window doesn't happen if it isn't present.
joedolson Jan 9, 2026
31a2e37
Bump VTS notice to 10 seconds.
joedolson Jan 9, 2026
0d2cc31
Tweaks to VTS alert styles
joedolson Jan 10, 2026
fe8d4a8
Fix todo comment text
joedolson Jan 10, 2026
359ba86
Enhance translations by supporting variables in translated strings
joedolson Jan 10, 2026
efe82f5
Localize VTS
joedolson Jan 10, 2026
b54a833
Accidentally removed entire tr.
joedolson Jan 10, 2026
f77d5ee
Pass data.text where trackText used to be.
joedolson Jan 10, 2026
4849653
Update comment
joedolson Jan 10, 2026
8b37b9f
Add VTS translations to language files.
joedolson Jan 10, 2026
bee61bb
Some comment improvements
joedolson Jan 10, 2026
ebc1f30
Merge pull request #712 from ableplayer/develop
joedolson Jan 10, 2026
e6d24bd
Update video5.html
joedolson Jan 10, 2026
21cc20d
Styling fixes for search2
joedolson Jan 10, 2026
1d813f5
Text fix now that YouTube is supported without captions
joedolson Jan 10, 2026
39e9367
Commit build files
joedolson Jan 10, 2026
811f573
Merge pull request #716 from ableplayer/develop
joedolson Jan 10, 2026
a04fe82
Update changelog.md
joedolson Jan 10, 2026
802287a
Merge pull request #717 from ableplayer/develop
joedolson Jan 10, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add preference enabling users to disable custom keyboard shortcuts
Fixes #408

Adds new translatable string.
  • Loading branch information
joedolson committed Dec 31, 2025
commit 384704661a93809c5a9fb44c837d1f450fc5ee4f
9 changes: 6 additions & 3 deletions scripts/event.js
Original file line number Diff line number Diff line change
Expand Up @@ -375,12 +375,15 @@
}

AblePlayer.prototype.okToHandleKeyPress = function () {

// returns true unless user's focus is on a UI element
let defaultReturn = true;
if ( this.prefNoKeyShortcuts === 1 ) {
defaultReturn = false;
}
// returns true unless user's focus is on a UI element or user has disabled keyboard shortcuts.
// that is likely to need supported keystrokes, including space
var activeElement = AblePlayer.getActiveDOMElement();

return ($(activeElement).prop('tagName') === 'INPUT') ? false : true;
return ($(activeElement).prop('tagName') === 'INPUT') ? false : defaultReturn;
};

AblePlayer.prototype.onPlayerKeyPress = function (e) {
Expand Down
25 changes: 21 additions & 4 deletions scripts/preference.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@
'group': 'keyboard',
'default': 0
});
prefs.push({
'name': 'prefNoKeyShortcuts',
'label': this.translate( 'prefNoKeyShortcuts', 'Disable Keyboard Shortcuts' ),
'group': 'keyboard',
'default': 0
});

// Transcript preferences
prefs.push({
Expand Down Expand Up @@ -586,10 +592,18 @@
changedSpan = '.able-modkey-shift';
changedText = thisObj.tt.prefShiftKey + ' + ';
}
if ($(this).is(':checked')) {
$(changedSpan).text(changedText);
if ( changedPref !== 'prefNoKeyShortcuts' ) {
if ($(this).is(':checked')) {
$(changedSpan).text(changedText);
} else {
$(changedSpan).text('');
}
} else {
$(changedSpan).text('');
if ($(this).is(':checked')) {
$('.able-modkey-item').addClass('hidden');
} else {
$('.able-modkey-item').removeClass('hidden');
}
}
});
}
Expand Down Expand Up @@ -624,6 +638,8 @@
this.currentSampleText = this.translate( 'sampleDescriptionText', 'Adjust settings to hear this sample text.' );
}
} else if (form === 'keyboard') {
let shortcutClass = (this.prefNoKeyShortcuts === 1 ) ? 'able-modkey-item hidden' : 'able-modkey-item';

// add a current list of keyboard shortcuts
$kbHeading = $('<h2>',{
text: this.translate( 'prefHeadingKeyboard2', 'Current keyboard shortcuts' )
Expand Down Expand Up @@ -705,7 +721,8 @@
kbListText += '<span class="able-modkey">' + keys[i] + '</span>';
kbListText += ' = ' + kbLabels[i];
$kbListItem = $('<li>',{
html: kbListText
'class': shortcutClass,
html: kbListText,
});
$kbList.append($kbListItem);
}
Expand Down
4 changes: 4 additions & 0 deletions styles/ableplayer.css
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,10 @@ div.able-modal-overlay {
margin-top: 1rem;
}

.able-modkey-item.hidden {
display: none;
}

.able-modal-header {
display: flex;
justify-content: space-between;
Expand Down
1 change: 1 addition & 0 deletions translations/ca.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Majúscula",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escapada",
"escapeKeyFunction": "Tanca el diàleg o finestre emergent actual",
"prefDescFormat": "Format preferit",
Expand Down
1 change: 1 addition & 0 deletions translations/cs.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Zavřít aktuální dialogové okno nebo vyskakovací nabídku",
"prefDescFormat": "Preferovaný formát",
Expand Down
1 change: 1 addition & 0 deletions translations/da.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Ctrl",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Luk nuværinde dialog eller popup-menu",
"prefDescFormat": "Foretrukne format",
Expand Down
1 change: 1 addition & 0 deletions translations/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Strg",
"prefShiftKey": "Umschalttaste",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "ESC Taste",
"escapeKeyFunction": "Dialogfenster schließen",
"prefDescFormat": "Bevorzugtes Format",
Expand Down
1 change: 1 addition & 0 deletions translations/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Close current dialog or popup menu",
"prefDescFormat": "Preferred format",
Expand Down
1 change: 1 addition & 0 deletions translations/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Mayúsculas",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Cerrar el cuadro de diálogo o menú contextual",
"prefDescFormat": "Formato preferido",
Expand Down
1 change: 1 addition & 0 deletions translations/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Ctrl",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Esc",
"escapeKeyFunction": "Fermer la fenêtre de dialogue ou le menu contextuel",
"prefDescFormat": "Format privilégié",
Expand Down
1 change: 1 addition & 0 deletions translations/he.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "סגור את תיבת הדו שיח הנוכחית או תפריט קופץ",
"prefDescFormat": "פורמט מועדף",
Expand Down
1 change: 1 addition & 0 deletions translations/id.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Tutup dialog atau menu sembulan yang tampil",
"prefDescFormat": "Format yang dipilih",
Expand Down
1 change: 1 addition & 0 deletions translations/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Chiude il menu o la finestra corrente",
"prefDescFormat": "Formato preferito",
Expand Down
1 change: 1 addition & 0 deletions translations/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "エスケープ",
"escapeKeyFunction": "現在のダイアログやポップアップメニューを閉じる",
"prefDescFormat": "フォーマットの選択",
Expand Down
1 change: 1 addition & 0 deletions translations/ms.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Tutup dialog atau menu popup semasa",
"prefDescFormat": "Format pilihan",
Expand Down
1 change: 1 addition & 0 deletions translations/nb.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Lukk dialogboks eller popup-meny",
"prefDescFormat": "Foretrukket format",
Expand Down
1 change: 1 addition & 0 deletions translations/nl.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Sluit huidige dialoog of popup menu",
"prefDescFormat": "Voorkeurs formaat",
Expand Down
1 change: 1 addition & 0 deletions translations/pl.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Zamknij bieżące okno dialogowe lub menu podręczne",
"prefDescFormat": "Preferowany format",
Expand Down
1 change: 1 addition & 0 deletions translations/pt-br.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "ESC",
"escapeKeyFunction": "Fechar diálogo ou caixa pop-up atual",
"prefDescFormat": "Preferência de formatos",
Expand Down
1 change: 1 addition & 0 deletions translations/pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Fecha o diálogo ou menu popup",
"prefDescFormat": "Formato preferido",
Expand Down
1 change: 1 addition & 0 deletions translations/sv.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Ctrl",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Stäng nuvarande dialog eller popupmeny",
"prefDescFormat": "Föredraget format",
Expand Down
1 change: 1 addition & 0 deletions translations/tr.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Control",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Escape",
"escapeKeyFunction": "Şu anki diyalogu veya açılır menüyü kapa",
"prefDescFormat": "Tecih edilen format",
Expand Down
1 change: 1 addition & 0 deletions translations/zh-tw.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"prefAltKey": "Alt",
"prefCtrlKey": "Ctrl",
"prefShiftKey": "Shift",
"prefNoKeyShortcuts": "Disable keyboard shortcuts",
"escapeKey": "Esc",
"escapeKeyFunction": "關閉目前的對話視窗或彈出式選單",
"prefDescFormat": "偏好格式",
Expand Down
Loading