algorithm: palindrome number#93
Closed
fatima-0000 wants to merge 4 commits into
Closed
Conversation
appgurueu
reviewed
Jan 24, 2023
|
|
||
| describe("IsPalindrome", () => { | ||
| test.each([[5, true], [1234, false], [12321, true], [32.23, true], [31343, false]])( | ||
| "correct output for for %i", |
appgurueu
reviewed
Jan 24, 2023
| let stringValue = number.toString(); | ||
| let length = stringValue.length - 1; | ||
| for (let i = length; i >= 0; --i) { | ||
| reverseString = reverseString + stringValue[i]; |
Contributor
There was a problem hiding this comment.
Why build a reverse string using repeated string concatenations when you could instead just check character-wise equality right in this loop?
Contributor
|
@appgurueu This can now be closed. Finished in #118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this pr is to add the is_palindrome algorithm in the maths algorithms. It checks whether a given number is a palindrome or not.